Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove virtual memory support #408

Merged
merged 4 commits into from
Aug 14, 2022
Merged

Remove virtual memory support #408

merged 4 commits into from
Aug 14, 2022

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Aug 14, 2022

Benchmarks show that the virtual_memory support in wasmi actually regresses performance compared to the naive Vec-based implementation. Also it complicates configuration space and therefore makes testing more difficult.
Furthermore we do not have a real use for virtual memory in Substrate or Polkadot for wasmi.

This feature also prevented us from using windows-latest in CI and we had to fall back onto windows-2019.

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2022

Codecov Report

Merging #408 (a58ece9) into master (baab359) will increase coverage by 0.50%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
+ Coverage   76.22%   76.73%   +0.50%     
==========================================
  Files          70       68       -2     
  Lines        6788     6743      -45     
==========================================
  Hits         5174     5174              
+ Misses       1614     1569      -45     
Impacted Files Coverage Δ
wasmi_v1/src/memory/byte_buffer.rs 89.47% <ø> (ø)
wasmi_v1/src/memory/mod.rs 68.69% <0.00%> (+1.74%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

We were required to use windows-2019 because of the virtual memory feature which is removed now.
@Robbepop Robbepop merged commit 10f8780 into master Aug 14, 2022
@Robbepop Robbepop deleted the rf-remove-vmem branch August 14, 2022 07:26
ark0f added a commit to gear-tech/wasmi that referenced this pull request Jul 10, 2023
ark0f added a commit to gear-tech/wasmi that referenced this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants