Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks show that the
virtual_memory
support inwasmi
actually regresses performance compared to the naiveVec
-based implementation. Also it complicates configuration space and therefore makes testing more difficult.Furthermore we do not have a real use for virtual memory in Substrate or Polkadot for
wasmi
.This feature also prevented us from using
windows-latest
in CI and we had to fall back ontowindows-2019
.