Refactor and clean up benchmark code #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robbepop
changed the title
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
=======================================
Coverage 79.56% 79.56%
=======================================
Files 31 31
Lines 4738 4738
=======================================
Hits 3770 3770
Misses 968 968
Continue to review full report at Codecov.
|
athei
approved these changes
Jan 4, 2022
benches/src/lib.rs
Outdated
Comment on lines
33
to
37
| // Parses the Wasm binary at the given file name into a `wasmi` module. | ||
| // | ||
| // # Note | ||
| // | ||
| // This includes validation and compilation to `wasmi` bytecode. |
There was a problem hiding this comment.
May be worth converting to rust doc while you at it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.watfiles into their own files.