Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #17 #18

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Resolve #17 #18

merged 3 commits into from
Jan 25, 2024

Conversation

dhil
Copy link
Member

@dhil dhil commented Jan 25, 2024

This patch (re)installs the check for continuation type well-formedness.

Currently, it allows only continuation types to be indexed by plain function types.

@dhil dhil requested a review from rossberg January 25, 2024 10:28
@dhil
Copy link
Member Author

dhil commented Jan 25, 2024

Should we allow indices which are recursive function groups too?

@rossberg
Copy link

It should allow anything that expands to a function type.

@dhil
Copy link
Member Author

dhil commented Jan 25, 2024

I revisited the code. I realised it already handles recursive groups, as the func_type internally expands the definition. I have added two more tests.

This patch (re)installs the check for continuation type
well-formedness.
interpreter/valid/valid.ml Outdated Show resolved Hide resolved
interpreter/valid/valid.ml Outdated Show resolved Hide resolved
dhil and others added 2 commits January 25, 2024 16:05
Co-authored-by: Andreas Rossberg <[email protected]>
Co-authored-by: Andreas Rossberg <[email protected]>
@dhil dhil merged commit a9ec313 into wasmfx:main Jan 25, 2024
1 check passed
@dhil dhil deleted the wasmfx-wf-conts branch January 25, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants