Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for (register) command in spec tests and enable importing mutable globals. #623

Merged
merged 4 commits into from
Aug 3, 2019
Merged

Add support for (register) command in spec tests and enable importing mutable globals. #623

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2fabb5b
Add support for (register) command in spec tests and enable importing…
nlewycky Aug 2, 2019
546969a
These tests are fixed too.
nlewycky Aug 2, 2019
59ef811
Update readme.
nlewycky Aug 2, 2019
9fcb06a
Missed a line!
nlewycky Aug 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update readme.
  • Loading branch information
@nlewycky
nlewycky committed Aug 2, 2019
commit 59ef811b469b121f252eb688ac222c74ca4b256e
4 changes: 2 additions & 2 deletions lib/spectests/spectests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Currently supported command assertions:
- [x] `assert_malformed` _fully implemented_
- [ ] `assert_uninstantiable` _not implemented yet_
- [ ] `assert_exhaustion` _not implemented yet_
- [ ] `register` _not implemented yet_
- [x] `register` _fully implemented_
- [x] `perform_action` _partially implemented, only function invocations for now_

### Covered spec tests
Expand Down Expand Up @@ -86,6 +86,7 @@ The following spec tests are currently covered:
- [x] return.wast
- [x] select.wast
- [x] set_local.wast
- [x] simd.wast
- [ ] skip-stack-guard-page.wast
- [x] stack.wast
- [x] start.wast
Expand All @@ -108,7 +109,6 @@ The following spec tests are currently covered:

There are some cases that we decided to skip for now to accelerate the release schedule:

- `SKIP_MUTABLE_GLOBALS`: Right now the Wasm parser can't validate a module with imported/exported `mut` globals. We decided to skip the tests until Cranelift and wasmparser can handle this (see [original spec proposal](https://github.com/WebAssembly/mutable-global)). Spec tests affected:
- `globals.wast`
- `SKIP_CALL_INDIRECT_TYPE_MISMATCH`: we implemented traps in a fast way. We haven't yet covered the type mismatch on `call_indirect`. Specs affected:

Expand Down