Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extension) Replace rust-cpython with pyo3 #7

Merged
merged 16 commits into from
Apr 13, 2019

Conversation

Hywan
Copy link
Contributor

@Hywan Hywan commented Apr 13, 2019

This patch replaces the rust-cpython crate by the pyo3 crate.

  1. Rust nightly is required to compile the extension (Compile with stable rust PyO3/pyo3#5),
  2. pyo3 is more active,
  3. Remove support for Python 2 (wasn't working before anyway),
  4. Allow to declare getters and __call__: We can now introduce this new API: instance.exports['sum'](1, 2) instead of instance.call('sum', [Value.i32(1), Value.i32(2)]),
  5. Simpler error/exception API,
  6. Much simpler code: Ease contributions,
  7. Faster compilation,
  8. Doesn't impact the publishing process (i.e. pushing wheels on pypi),
  9. Remove the Shell hack.

@Hywan Hywan added 🎉 enhancement New feature or request 📚 documentation Do you like to read? 🧪 tests I love tests 📦 component-extension About the Python extension written in Rust 📦 component-runtime About the Wasm runtime labels Apr 13, 2019
@Hywan Hywan self-assigned this Apr 13, 2019
@Hywan Hywan merged commit af9b2ef into wasmerio:master Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 component-extension About the Python extension written in Rust 📦 component-runtime About the Wasm runtime 📚 documentation Do you like to read? 🎉 enhancement New feature or request 🧪 tests I love tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants