Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for automatic detection of inverter type #24

Merged
merged 13 commits into from
Nov 17, 2024

Conversation

wasilukm
Copy link
Owner

@wasilukm wasilukm commented Nov 17, 2024

Inverter type is auto-detected, supported inverter series are MI (serial number starting with 10) and HM (serial number starting with 11)

This includes breaking changes:

  • removed microinverter_type parameter from HoymilesModbusTCP
  • data structures MISeriesMicroinverterData and replaced by InverterData
  • renamed PlantData.microinverter_data to PlantData.inverters
  • renamed HoymilesModbusTCP.microinverter_data to HoymilesModbusTCP.inverters

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 97.01493% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.10%. Comparing base (53161a3) to head (e3f65e0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
hoymiles_modbus/client.py 89.47% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   98.61%   98.10%   -0.51%     
==========================================
  Files           3        3              
  Lines         144      158      +14     
  Branches       19       11       -8     
==========================================
+ Hits          142      155      +13     
- Partials        2        3       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wasilukm wasilukm merged commit 3634bde into main Nov 17, 2024
4 of 6 checks passed
@wasilukm wasilukm deleted the inverter_autodetect branch November 17, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant