New feature: --mqtt-topic #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR contains more changes than described. Could you please limit them to only changes related to MQTT topic? This will make review and verification easier. |
|
These PRs aren't moving and I'm working on multiple issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MQTT shouldn't be that tightly coupled into Home Assistant.
In MQTT there is no discovery, in Home Assistant there is.
As there might be multiple subscribes to change topic, binding it with a hard-coded value into Home Assistant isn't especially good approach.
Having the topic default into previous value, there is no breaking change. However, soft-coding the topic improves feasibility to any setup, enabling the MQTT topics to be arranged as best suited.
Note:
As Home Assistant depends heavily with the discovery and given discovery topic can not be changed, moving the actual data feed does not break existing Home Assistant setups at all. HA simply reads the data from new topics without gaps in the existing data.