Flake 8 formatting fixes #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve-handle-exceptions Scrape archiving: handle exceptions so archiving doesn't fail scrape
…-other-names-lookup Update organization other_names lookup
…es-matching-release Mark for minor release
…-chamber-context Use incoming Chamber in resolve_person() to improve sponsorship matches
Events to Bills: Add -1 Day to Match Query
…lve-person Add organization_classification to resolve_person context
…te-length-limited-varchar-to-text Revert "DB migrate length limited varchar to text"
…t-import Avoid DB import bugs by trimming strings at import transform
Desitrain22
changed the title
- Fixed in-line comment formatting on settings.py - single quotes for re-formatted docs - double quotes for interprolation/placeholder values
- Added type hints to kafka producer initializer function - ignored missing imports to deal with issue of no stubs for boto3 and kafka
Clean up phone
…into pull-from-os
…e on legisltaive session quality check before introducing end date
jessicabowden
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this P.R, we're merging all the changes from the upstream to date. In addition, we're making the necessary changes to be compliant with the linting and pytest constraights
update.pyandsettings.pyto be flake8 compliant. Specifically, we are using the black formatter, but manually adjusting to make sure we use single quotes instead of double.'self.kafka', which should've been the parameter'kafka_cluster_name'. In addition, we're removing an unnecessary import of kafka producers at thebase.pylevel. This is to resolve a recent issue at the build/push level. (Note that this is a test suite defined upstream)scrape/tests/test_jurisdiction_scrape.pyand the schema to include our implementedhistorical_legislative_scrapes