Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auto-merge.yml #201

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Update auto-merge.yml #201

merged 1 commit into from
Oct 31, 2022

Conversation

warting
Copy link
Owner

@warting warting commented Oct 30, 2022

No description provided.

@warting warting enabled auto-merge (rebase) October 30, 2022 21:23
@@ -18,11 +18,10 @@
val composeVersion = "1.2.0-beta02"

android {
compileSdk = 31
compileSdk = 33

Check warning

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers.

This expression contains a magic number. Consider defining it to a well named constant.

android {
compileSdk = 31
compileSdk = 33

Check warning

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers.

This expression contains a magic number. Consider defining it to a well named constant.

defaultConfig {
applicationId = "se.warting.permissionsui"
minSdk = 21
targetSdk = 31
targetSdk = 33

Check warning

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers.

This expression contains a magic number. Consider defining it to a well named constant.
}

android {
compileSdk = 31
compileSdk = 33

Check warning

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers.

This expression contains a magic number. Consider defining it to a well named constant.

defaultConfig {
applicationId = "se.warting.permissionsuijava"
minSdk = 21
targetSdk = 31
targetSdk = 33

Check warning

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers.

This expression contains a magic number. Consider defining it to a well named constant.
@warting warting merged commit 928454c into main Oct 31, 2022
@warting warting deleted the warting-patch-1 branch October 31, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant