Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix links to install.sh #432

Merged
merged 2 commits into from
May 22, 2024
Merged

docs: Fix links to install.sh #432

merged 2 commits into from
May 22, 2024

Conversation

yermulnik
Copy link
Collaborator

Fix links to install.sh after moving from release to master branch as main branch

fixes #431

@yermulnik
docs: Fix links to install.sh
8392514 
Fix links to `install.sh` after moving from `release` to `master` branch
as main branch

fixes #431
@MatthewJohn
Copy link
Collaborator

I also noted a day ago, whilst trying to use the installer, that the installer doesn't work for any releases prior to v1.1.0 (so only supports the latest 2 versions) - or is that due to the old version of the script being used by the instructions, which this PR fixes? :)

@MatthewJohn
Copy link
Collaborator

I also noted a day ago, whilst trying to use the installer, that the installer doesn't work for any releases prior to v1.1.0 (so only supports the latest 2 versions) - or is that due to the old version of the script being used by the instructions, which this PR fixes? :)

Ah, it does - ignore me :)

MatthewJohn
MatthewJohn approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@MatthewJohn MatthewJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@yermulnik yermulnik merged commit 4c24d53 into master May 22, 2024
3 checks passed
@yermulnik yermulnik deleted the docs/fix_links_to_install_script branch May 22, 2024 19:00
@yermulnik
Copy link
Collaborator Author

yermulnik commented May 22, 2024 •
edited
Loading

JFYI: pushed WWW docs to https://tfswitch.warrensbox.com/ manually (as in using mkdocs from within repo)

@warrensbox warrensbox added the documentation Add or improve documentation: README/CHANGELOG/comments on code label May 24, 2024
@warrensbox warrensbox added this to the Release 1.2.0 milestone May 24, 2024
MatthewJohn added a commit to MatthewJohn/terrareg that referenced this pull request May 24, 2024
@MatthewJohn
build: Use master branch for tfswitch installer, which contains fix f…
4923e3d 
…or installing legacy version

See warrensbox/terraform-switcher#432

Issue #518
Klyde-Moradeyo added a commit to Klyde-Moradeyo/terrareg that referenced this pull request Jun 2, 2024
@Klyde-Moradeyo
Bump Terra-reg to 3.4.2
452c865 
commit b93a084
Author: semantic-release-bot <[email protected]>
Date:   Sun May 26 12:06:19 2024 +0000

    chore(release): 3.4.2

    ## [3.4.2](https://gitlab.dockstudios.co.uk/pub/terrareg/compare/v3.4.1...v3.4.2) (2024-05-26)

    ### Bug Fixes

    * Ensure user-agent matches expected Terraform or OpenTofu user agents ([83ee182](https://gitlab.dockstudios.co.uk/pub/terrareg/commit/83ee18215c818cf59151b7aabf35803f3bc96b21)), closes [#519](https://gitlab.dockstudios.co.uk/pub/terrareg/issues/519)

commit 7b3cc0a
Merge: 42859a5 7eea51d
Author: Matt <[email protected]>
Date:   Sun May 26 11:06:07 2024 +0000

    Merge branch '519-ignore-terraform-version-from-tfsec-in-analytics' into 'main'

    fix: Ensure user-agent matches expected Terraform or OpenTofu user agents

    Closes #519

    See merge request pub/terrareg!404

commit 7eea51d
Merge: ef177bb 42859a5
Author: Matthew John <[email protected]>
Date:   Fri May 24 07:09:28 2024 +0100

    Merge branch 'main' into 519-ignore-terraform-version-from-tfsec-in-analytics

commit 42859a5
Merge: 329a683 4923e3d
Author: Matt <[email protected]>
Date:   Fri May 24 05:04:27 2024 +0000

    Merge branch '518-terraform-switch-installation-fails' into 'main'

    Resolve "terraform-switch installation fails"

    Closes #518

    See merge request pub/terrareg!398

commit 4923e3d
Author: Matthew John <[email protected]>
Date:   Thu May 23 20:18:07 2024 +0100

    build: Use master branch for tfswitch installer, which contains fix for installing legacy version

    See warrensbox/terraform-switcher#432

    Issue #518

commit 0c993df
Author: Matthew John <[email protected]>
Date:   Thu May 23 20:17:26 2024 +0100

    Revert "fix: Upgrade terraform-switcher to v1.1.1 to fix installation in Dockerfile"

    This reverts commit c044578.

    Issue #518

commit ef177bb
Author: Matthew John <[email protected]>
Date:   Wed May 22 06:24:02 2024 +0100

    chore: Add typing to parameter for get_environment_from_token to mark as being None-able

    Issue #519

commit 83ee182
Author: Matthew John <[email protected]>
Date:   Wed May 22 06:21:22 2024 +0100

    fix: Ensure user-agent matches expected Terraform or OpenTofu user agents

    This stops other applications, such as tfsec, from downloading modules and recording analytics with arbitrary version numbers.
    Update tests to set user agent accordingly and create test to ensure record_module_version_download checks user agent correctly.

    Issue #519

commit c044578
Author: Matthew John <[email protected]>
Date:   Tue May 21 07:40:12 2024 +0100

    fix: Upgrade terraform-switcher to v1.1.1 to fix installation in Dockerfile

    The install script now expects v prefix in name of artifacts, which is not present in older versions.

    Issue #518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewJohn MatthewJohn MatthewJohn approved these changes

@warrensbox warrensbox Awaiting requested review from warrensbox warrensbox is a code owner

@jukie jukie Awaiting requested review from jukie jukie is a code owner

@MatrixCrawler MatrixCrawler Awaiting requested review from MatrixCrawler MatrixCrawler is a code owner

@crablab crablab Awaiting requested review from crablab crablab is a code owner

Assignees
No one assigned
Labels
documentation Add or improve documentation: README/CHANGELOG/comments on code
Projects
None yet
Milestone
Release 1.2.0
Development

Successfully merging this pull request may close these issues.

Install script issue
3 participants
@yermulnik @MatthewJohn @warrensbox