Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update stalebot configurations #122

Merged
merged 3 commits into from
Jan 21, 2024
Merged

chore: update stalebot configurations #122

merged 3 commits into from
Jan 21, 2024

Conversation

mugdha-adhav
Copy link
Collaborator

@mugdha-adhav mugdha-adhav commented Jan 20, 2024

closes #121

What's changed

  • Skip adding stale label on any issues/PRs with any milestone.
  • Add issue/PR specific days before stale and close values.

Note: These values are not finalized. We would like to try them out for a few months and update them if required.

Skip adding stale label on any issues/PRs with any milestone.

Add issue/PR specific days before stale value.
@mugdha-adhav mugdha-adhav requested a review from a team as a code owner January 20, 2024 16:27
@mugdha-adhav
Copy link
Collaborator Author

closes #121

@mugdha-adhav mugdha-adhav self-assigned this Jan 20, 2024
@mbtamuli
Copy link
Contributor

@mugdha-adhav If you want the merged PR to close the issue automatically, you have to update the description/first comment. - https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@mbtamuli
Copy link
Contributor

mbtamuli commented Jan 20, 2024

I know it isn't related, but could you also update the dependabot commit message prefix in this PR? Perfectly fine to tackle this separately.

https://github.com/warm-metal/csi-driver-image/blob/1fb572f70c2de16c4258dc720e539ba74198b23e/.github/dependabot.yml#L9

I was thinking of having the prefix be - chore: [skip ci]. That'll set us up for conventional commit messages.

It should turn this commit's message
from Bump helm/kind-action from 1.4.0 to 1.8.0
to chore: [skip ci] Bump helm/kind-action from 1.4.0 to 1.8.0

@mugdha-adhav
Copy link
Collaborator Author

but could you also update the dependabot commit message prefix in this PR?

Yes, I have updated it.

@mbtamuli
Copy link
Contributor

@mugdha-adhav If you want the merged PR to close the issue automatically, you have to update the description/first comment. - https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

FYI, since you haven't linked the issue with the PR correctly, the PR #121 doesn't show the PR in the development section of the issue. A maintainer will have to do the double work of merging the PR as well as closing the issue.
image

@mugdha-adhav mugdha-adhav merged commit cb16287 into warm-metal:master Jan 21, 2024
@mugdha-adhav mugdha-adhav deleted the experimental/configure-stale-bot branch January 21, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stalebot seems too aggresive
2 participants