Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Address outdated issues and PRs #114

Merged
merged 4 commits into from
Jan 15, 2024
Merged

ci: Address outdated issues and PRs #114

merged 4 commits into from
Jan 15, 2024

Conversation

mbtamuli
Copy link
Contributor

Closes #95

@mbtamuli
lots and lots of changes
095f839 
Signed-off-by: Mriyam Tamuli <[email protected]>
@mbtamuli mbtamuli requested a review from a team as a code owner January 14, 2024 09:54
@mbtamuli
Copy link
Contributor Author

@mugdha-adhav Please set a DEBUG_ONLY variable with value true before you merge. If the configuration/output looks fine, you can delete the variable and allow the workflow to run.

See: Creating configuration variables for a repository

mugdha-adhav
mugdha-adhav reviewed Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@mugdha-adhav mugdha-adhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also add (even if small and precise) documentation for these changes in docs/ folder?

@mbtamuli mbtamuli requested a review from mugdha-adhav January 15, 2024 05:49
mugdha-adhav
mugdha-adhav reviewed Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@mugdha-adhav mugdha-adhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation is 🏆 🥇

@mugdha-adhav
Copy link
Collaborator

@mugdha-adhav Please set a DEBUG_ONLY variable with value true before you merge. If the configuration/output looks fine, you can delete the variable and allow the workflow to run.

@mbtamuli should I delete this variable after merging the PR?

@mbtamuli
Copy link
Contributor Author

@mugdha-adhav Maybe after one debug/dry run? #114 (comment)

@mugdha-adhav mugdha-adhav merged commit 63ba8b7 into warm-metal:master Jan 15, 2024
6 checks passed
@mbtamuli mbtamuli deleted the ci/stale branch January 15, 2024 06:26
@mugdha-adhav mugdha-adhav mentioned this pull request Jan 15, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mugdha-adhav mugdha-adhav mugdha-adhav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outdated GitHub issues are dangling around
2 participants
@mbtamuli @mugdha-adhav