Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note in userdoc regarding dracut and machine-id #1609

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

ssimpson89
Copy link
Contributor

@ssimpson89 ssimpson89 commented Jan 2, 2025

Description of the Pull Request (PR):

In Rocky Linux 8, running the provided dracut command does not create the initramfs in a place where Warewulf is expecting it and thus fails to pull the image during the two stage boot. The fix appears to be to remove machine-id from /etc. This documentation PR reflects that

Reviewer checklist

The reviewer checks the following items before merging the PR.

  • The PR is based on the appropriate branch (typically main)
  • All commits are "Signed off" (e.g., using git commit --signoff) in agreement to the DCO
  • The CHANGELOG has been updated, if necessary, and under the correct release heading
  • The userdocs have been updated, if necessary
  • The submitter is listed in the contributors file
  • The test suite has been updated, if necessary

@anderbubble anderbubble added the documentation Improvements or additions to documentation label Jan 3, 2025
@anderbubble anderbubble added this to the v4.6.0 milestone Jan 3, 2025
@anderbubble
Copy link
Collaborator

@ssimpson89 thanks! Please...

  • squash these commits together
  • add yourself to the CONTRIBUTORS file
  • update the CHANGELOG
  • sign-off on the commit

Thanks again!

@anderbubble
Copy link
Collaborator

Also, @ssimpson89, in the future, I recommend always submitting PRs from a separate feature branch, not from your own main.

@anderbubble anderbubble self-requested a review January 3, 2025 17:43
Copy link
Collaborator

@anderbubble anderbubble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • squash these commits together
  • add yourself to the CONTRIBUTORS file
  • update the CHANGELOG
  • sign-off on the commit

This note informs that it may be necessary to remove /etc/machine-id for dracut to properly generate. The nodes will fail to boot otherwise
@ssimpson89
Copy link
Contributor Author

I believe I have made all the requested changes

@anderbubble
Copy link
Collaborator

It looks like you missed the --signoff during commit; but I'll go ahead and merge for this PR; just keep that in mind for the future.

Thanks!

@anderbubble anderbubble merged commit 3bbe859 into warewulf:main Jan 6, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants