[JA] Add support for Hiragana #511
Conversation
test/ja/ja_casual.test.ts
Outdated
| testSingleCase(chrono.ja, "今日感じたことを忘れずに", new Date(2012, 8 - 1, 10, 12), (result) => { | ||
| expect(result.index).toBe(0); | ||
| expect(result.text).toBe("今日"); | ||
| function testToday(pattern: string) { |
There was a problem hiding this comment.
Could you not use a function like this and repeat testSingleCase() for each case?
I know it's a lot of duplicated code, but we want to ensure the tests are really straightforward. (e.g. if the expect fails it would be more difficult to see where we break the test).
There was a problem hiding this comment.
we want to ensure the tests are really straightforward
I absolutely agree with you.
I'll make the tests like so and maybe with less assertions like you mentioned here
test/ja/ja_casual.test.ts
Outdated
| expect(result.start.get("year")).toBe(2012); | ||
| expect(result.start.get("month")).toBe(8); | ||
| expect(result.start.get("day")).toBe(10); | ||
| expect(result.start).toBeDate(new Date(2012, 8 - 1, 10, 12)); |
There was a problem hiding this comment.
I think, previously, we test too many things. e.g. only expect(result.start).toBeDate() and maybe expect(result.text) is enough.
There was a problem hiding this comment.
Will do so accordingly 👍
| const PATTERN = /今日|当日|昨日|明日|今夜|今夕|今晩|今朝/i; | ||
| const PATTERN = /今日|きょう|当日|とうじつ|昨日|きのう|明日|あした|今夜|こんや|今夕|こんゆう|今晩|こんばん|今朝|けさ/i; | ||
|
|
||
| function normalizeTextToKanji(str: string) { |
There was a problem hiding this comment.
Nit: text not str, because your function name is normalizeTextToKanji, not normalizeStrToKanji.
|
Hello @yuichkun. Thank you so much for the change. Could you please take a look at my comments, especially about the test? |
|
Hi @wanasit , |
|
I apologize that I forgot to publish the new version for months. |
TL;DR
This PR adds support for Hiragana(ひらがな) in the Japanese date parser.
I didn't know the best way of treating Hiragana/Kanji, so for now I just did it in the most straight forward, or redundant way.
If you have any thoughts on how to improve this, I'd love to challenge myself!
In addition to adding support for Hiragana, I also added some test cases that seemed to be missing.
Btw, thank you so much for writing this library, and I really appreciate how well this library is maintained.