fix: ParsingComponent.get() to return undefined instead of null

wanasit · Jul 18, 2020 · e1a3c04 · e1a3c04
1 parent a1757f3
commit e1a3c04
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -32,7 +32,7 @@ export interface ParsedResult {
 
 export interface ParsedComponents {
     readonly isCertain: (c: Component) => boolean;
-    readonly get: (c: Component) => number | undefined;
+    readonly get: (c: Component) => number | null;
     readonly date: () => Date;
 }
 

diff --git a/src/results.ts b/src/results.ts
@@ -34,7 +34,7 @@ export class ParsingComponents implements ParsedComponents {
             return this.impliedValues[component];
         }
 
-        return null;
+        return undefined;
     }
 
     date(): Date {
@@ -125,7 +125,7 @@ export class ParsingComponents implements ParsedComponents {
         // Javascript Date Object return minus timezone offset
         const currentTimezoneOffset = result.utcOffset();
         const targetTimezoneOffset =
-            this.get("timezoneOffset") !== null ? this.get("timezoneOffset") : currentTimezoneOffset;
+            this.get("timezoneOffset") !== undefined ? this.get("timezoneOffset") : currentTimezoneOffset;
 
         const adjustTimezoneOffset = targetTimezoneOffset - currentTimezoneOffset;
         result = result.add(-adjustTimezoneOffset, "minute");

diff --git a/test/result.test.ts b/test/result.test.ts
@@ -10,7 +10,7 @@ test("Test - Create & manipulate date results", () => {
     expect(components.date()).toBeDefined();
 
     // undefined
-    expect(components.get("weekday")).toBeNull();
+    expect(components.get("weekday")).toBeUndefined();
     expect(components.isCertain("weekday")).toBe(false);
 
     // "imply"