Fix: incorrect reference "for the ..."

wanasit · Dec 30, 2023 · 2cbe422 · 2cbe422
1 parent fed9f9d
commit 2cbe422
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 0 deletions.
diff --git a/src/locales/en/parsers/ENTimeUnitWithinFormatParser.ts b/src/locales/en/parsers/ENTimeUnitWithinFormatParser.ts
@@ -34,6 +34,11 @@ export default class ENTimeUnitWithinFormatParser extends AbstractParserWithWord
     }
 
     innerExtract(context: ParsingContext, match: RegExpMatchArray): ParsingComponents {
+        // Exclude "for the unit" phases, e.g. "for the year"
+        if (match[0].match(/^for\s*the\s*\w+/)) {
+            return null;
+        }
+
         const timeUnits = parseTimeUnits(match[1]);
         return ParsingComponents.createRelativeFromReference(context.reference, timeUnits);
     }

diff --git a/test/en/en_month.test.ts b/test/en/en_month.test.ts
@@ -68,6 +68,12 @@ test("Test - Month-Year expression", function () {
 
         expect(result.start).toBeDate(new Date(2012, 9 - 1, 1, 12));
     });
+
+    testSingleCase(chrono, "Statement of comprehensive income for the year ended Dec. 2021", (result) => {
+        expect(result.start.get("year")).toBe(2021);
+        expect(result.start.get("month")).toBe(12);
+        expect(result.text).toBe("Dec. 2021");
+    });
 });
 
 test("Test - Month-Only expression", function () {

diff --git a/test/en/en_month_name_middle_endian.test.ts b/test/en/en_month_name_middle_endian.test.ts
@@ -153,6 +153,13 @@ test("Test - Single Expression", () => {
         expect(result.start.get("month")).toBe(1);
         expect(result.start.get("day")).toBe(20);
     });
+
+    testSingleCase(chrono, "Dec. 21", new Date(2012, 7, 10), (result) => {
+        expect(result.text).toBe("Dec. 21");
+        expect(result.start.get("year")).toBe(2012);
+        expect(result.start.get("month")).toBe(12);
+        expect(result.start.get("day")).toBe(21);
+    });
 });
 
 test("Test - Single expression with separators", () => {

diff --git a/test/en/negative_cases.test.ts b/test/en/negative_cases.test.ts
@@ -75,6 +75,10 @@ test("Test - Skip version number pattern", () => {
     testUnexpectedResult(chrono, "Version: 1.10.30");
 });
 
+test("Test - Skip incorrect reference", () => {
+    testUnexpectedResult(chrono, "for the year");
+});
+
 test("Test - Date with version number pattern", () => {
     testSingleCase(chrono.en, "1.5.3 - 2015-09-24", (result) => {
         expect(result.text).toBe("2015-09-24");