concord-agent-operator: use informers API #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibodrov
force-pushed
the
ib/use-informers
branch
from
166d9e1 to
ec8d81c
Compare
ibodrov
force-pushed
the
ib/use-informers
branch
from
ec8d81c to
cd2f5ae
Compare
ibodrov
force-pushed
the
ib/use-informers
branch
from
cd2f5ae to
ce5044e
Compare
brig
reviewed
Jan 28, 2025
|
|
||
| @Override | ||
| public void onAdd(AgentPool resource) { | ||
| System.out.println("onAdd"); |
There was a problem hiding this comment.
let's put it into scheduler.onEvent :)
log.info("onEvent [{}, {}]", type, resource); // or something from `resource` :)
There was a problem hiding this comment.
Oops, should not be there. I will add the log though -- good idea.
ibodrov
force-pushed
the
ib/use-informers
branch
from
ce5044e to
19e6b3c
Compare
ibodrov
force-pushed
the
ib/use-informers
branch
from
19e6b3c to
9320ea2
Compare
ibodrov
force-pushed
the
ib/use-informers
branch
from
9320ea2 to
7d89b34
Compare
brig
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid "resource too old" issue when using "naked" Watchers.
As recommended here https://stackoverflow.com/a/61437982