Do not fail on symlinks that point to non-empty files, use default tar behavior #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m90
commented
Sep 3, 2021
| @@ -222,12 +222,16 @@ func createTestData() (string, string) { | |||
| panic(err) | |||
| } | |||
|
|
|||
| _, err = os.Create(filepath.Join(subDirectory, "my_file.txt")) | |||
| if err != nil { | |||
| if err := os.WriteFile(filepath.Join(subDirectory, "my_file.txt"), []byte("file contents"), 0666); err != nil { | |||
There was a problem hiding this comment.
This change is here so that the tests do not accidentally pass as all file's sizes are 0 in the previous suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this package in a Docker image I maintain and an issue was raised where it seems that
targzseems to fail on symlinks that point to non-empty files, failing with:It seems this is due to the fact that package
targzresolves symlinks to use the proper file instead, but still uses thefileInfoof the symlink itself, which means the size written to the header info does not match anymore.As for how to fix this there are two options:
targzuse the default behavior of thetarcommand which is keeping the symlink a symlink (potentially risking a broken symlink that points to something out of the bounds of the archive)targzuse the behavior that seems to be the one intended by the code (but isn't working), which is to resolve the symlinks and include their backing contentI opted for choosing 1 for now as it's the default of
tar, but if you feel like 2 is the better fit for this package I am happy to change this as again.As for the issue itself, you can repro this easily by checking out the first commit in this changeset which just updates the test setup to include a symlink to a non-empty file, which makes tests fail.