Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predefined Constants first #206

Closed
wants to merge 2 commits into from
Closed

Predefined Constants first #206

wants to merge 2 commits into from

Conversation

farwish
Copy link
Contributor

@farwish farwish commented Aug 26, 2017

No description provided.

@walkor
Copy link
Owner

walkor commented Aug 27, 2017

Sorry, the pull request is refused because there is no difference after merge the pull request.

@walkor walkor closed this Aug 27, 2017
@xpader
Copy link

xpader commented Aug 29, 2017

Use Constant is more good performance, why not merge it?
A little performance improvement.
No any bad things.

@walkor
Copy link
Owner

walkor commented Aug 29, 2017

There is no description for the pull request. And I see there is other changes(Merge pull request #1 from walkor/master …) which I not sure if it's ok.

A small performance here is not helpful for the business.
No any bad things but no any good things.

But still thanks to farwish.

@xpader
Copy link

xpader commented Aug 29, 2017

💀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants