Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for local file paths in $schema attributes #153

Merged
merged 5 commits into from
Apr 19, 2022
Merged

Add support for local file paths in $schema attributes #153

merged 5 commits into from
Apr 19, 2022

Conversation

brianespinosa
Copy link
Contributor

This resolves #152

Tests added for this use case and are passing when using act locally by running act -j test

@brianespinosa
Copy link
Contributor Author

@walbo sorry I didn't catch this yesterday, but it looks like you'll need to approve the workflows to run on this first PR.

@walbo
Copy link
Owner

walbo commented Apr 14, 2022

Thanks for the PR. Currently on easter holiday. Will take a look it after the break.

@walbo
Copy link
Owner

walbo commented Apr 19, 2022

Thanks for the contribution @brianespinosa

The PR looks good to me. Will create a new release in a couple of hours with the PR included.

@walbo walbo merged commit 9e45248 into walbo:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walbo walbo walbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use path to support local schemas in addition to URLs
2 participants
@brianespinosa @walbo