add option for configurable timeout and docs #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zerolab Hey, do you have by any chance time to review an merge this? For larger pages, the default timeout of ten seconds simply isn't enough, rendering the entire feature broken. Please let me know if you want me to change something. |
|
@Hafnernuss will have a look and make a release in the next few days. Thank you for the reminder |
zerolab
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option for the libretranslate machine translator to configure an optional timeout. The hardcoded 10 seconds might not be enough for large pages. The default is now set to 10 seconds.
Also updated the docs to reflect the new setting