-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Revision model change in Wagtail 4.0 #630
Conversation
@ArnarTumi any chance you could test this on your projects |
Codecov ReportBase: 91.77% // Head: 91.77% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #630 +/- ##
=======================================
Coverage 91.77% 91.77%
=======================================
Files 46 46
Lines 3950 3950
Branches 596 596
=======================================
Hits 3625 3625
Misses 192 192
Partials 133 133 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
9b5802a
to
78d8eda
Compare
this should cover: - adding localize to a Wagtail 4 project - upgrading a project using localize to Wagtail 4
78d8eda
to
ed0025f
Compare
Hey @zerolab I was able to install this both on wagtail 4.0.2 and wagtail 2.15.5 so this seems to be working :) |
@gasman will merge this as is tomorrow mid-morning, unless I hear otherwise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This looks like a very neat way of dealing with the unpredictability of the model name. I look forward to stealing it for wagtail-review :-)
Thank you! it took quite some trial and error. Lots of TILs in the process. I am both in awe and somewhat mystified by the power of Django migrations |
this should cover:
Fixes #629