Skip to content

Commit

Permalink
Remove action exports
Browse files Browse the repository at this point in the history
  • Loading branch information
w9jds committed Jun 11, 2022
1 parent 1aef4a7 commit 9ec7761
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 10 deletions.
2 changes: 1 addition & 1 deletion action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ outputs:

runs:
using: 'docker'
image: 'docker://w9jds/firebase-action:v2.2.1'
image: 'docker://w9jds/firebase-action:v2.2.2'
20 changes: 11 additions & 9 deletions entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,14 @@ if [ -n "$CONFIG_VALUES" ]; then
firebase functions:config:set "$CONFIG_VALUES"
fi

response=$(firebase $*)

if [ $? -eq 0 ]; then
echo "$response"
exit 0
else
echo "$response"
exit 1
fi
sh -c "firebase $*"

# response=$(firebase $*)

# if [ $? -eq 0 ]; then
# echo "$response"
# exit 0
# else
# echo "$response"
# exit 1
# fi

2 comments on commit 9ec7761

@crunk1
Copy link

@crunk1 crunk1 commented on 9ec7761 Jun 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for not exporting stdout? Also, the README.md still says "response" is an action output.

@RafaRuiz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be back

Please sign in to comment.