Remove Receiver-like traits with before_received from PSPs
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noc2
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Thanks a lot for creating the issue. I'm generally happy to merge it, but let me ping the original creators of the PSP one last time before I'm going to merge it.
@0xMarkian and @xgreenx do you have any input or concerns here?
|
Hey, thanks for mentioning us @Noc2 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before_receivedmethod was found as vulnerability point during ink! audit, that can be used with malicious intents by exhausting gas limit. So, the decision was to remove such method and Receiver-like traits.