Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amended application for the bit.country m2. #696

Merged
merged 15 commits into from
Nov 17, 2021
Merged

Conversation

justinphamnz
Copy link
Contributor

Good day,

As suggested in the original m2 application, we have amended the scope and deliverables in this application.

Changes logs.

Changes summary.
There are some changes from the original application.
The reason for the changes is that some UI features that were not aligned on our roadmap and we shifted more focus on delivering public testnet and canary network.

codemeit and others added 13 commits March 7, 2021 21:10
initial draft for m2.
Finalised the tasks in the milestone.
minor milestone text update
update team member
Change the amount to be USD as required.
Add bootstrap tasks for launching testnet.
Restructure and update wording to improve clarity of deliverables.
Add summary and considerations sections.
Tech stack and changing NFT native to support NFT
update Duration
@CLAassistant
Copy link

CLAassistant commented Nov 15, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Could you update the original contract and not create a new file?

@Noc2 Noc2 added the changes requested The team needs to clarify a few things first. label Nov 16, 2021
@justinphamnz
Copy link
Contributor Author

justinphamnz commented Nov 16, 2021

Thanks @Noc2 for the feedback, I just updated the original contract here
Please let me know if there is any change required.

Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Regarding 1b, instead of leasing functionality you want to implement fixed price sales? And this will be implemented within the Continuum pallet?
  • Can you expand on how NFT Sign Support works? Do you store any information on-chain?
  • What does NFT-Future-Event (e.g. time capsule) mean?
  • As a seller, what motive would I have to limit my sales to a local NFT market?

@justinphamnz
Copy link
Contributor Author

justinphamnz commented Nov 16, 2021

Thanks @semuelle. Please find the answers below.

  • Regarding 1b, instead of leasing functionality you want to implement fixed price sales? And this will be implemented within the Continuum pallet?

Yes, due to a big impact on coordinates change on the map engine after the lease expired as well as the business logic, we would like to park the leasing for now. We instead offer the fixed price set by the council for a certain period so metaverse can buy Continuum spot at a fixed price. The logic is on Continuum pallet.

  • Can you expand on how NFT Sign Support works? Do you store any information on-chain?

Sign to support NFT feature allows NFT holder can gain trust by getting signed by supporters, they can optionally contribute token which holds in that specific NFT fund. This not only support NFT financially but also publicity by number of supporters.

We store all information of supporters e.g AccountId on-chain.

  • What does NFT-Future-Event (e.g. time capsule) mean?

It's a special type of NFT that is only run by a game engine in a specific block. The execution logic handled off-chain.

  • As a seller, what motive would I have to limit my sales to a local NFT market?

There are some items in bit.country only available in local NFT market e.g land, subdivisions of that local metaverse. Global marketplace is designed for network-level item e.g raw land, global building, avatars and games. As a seller, really depends on what type of product you are selling.

Hope it answers your questions.

alxs
alxs previously approved these changes Nov 17, 2021
Copy link
Contributor

@alxs alxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. When do you intend to deliver?

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I have one more request: Could you maybe add the programming language to the deliverables? This might help to clarify a few things, for example I’m currently not sure how NFT Market will be implemented (UI, CLI, etc.).

@justinphamnz
Copy link
Contributor Author

LGTM. When do you intend to deliver?

Thanks @alxs. We are adding some more validation and unit tests on the newly added features to ensure all conditions are covered. We tend to make a delivery PR by the end of the week.

@justinphamnz
Copy link
Contributor Author

Looks good, but I have one more request: Could you maybe add the programming language to the deliverables? This might help to clarify a few things, for example I’m currently not sure how NFT Market will be implemented (UI, CLI, etc.).

Thanks David @Noc2.

I just updated the programming languages, the deliverables are developed on-chain so mainly Rust. The NFT marketplace deliverable logic is handled purely on-chain, we also will share the fully functional version through either Docker or UAT access.

@Noc2
Copy link
Collaborator

Noc2 commented Nov 17, 2021

Looks good, but I have one more request: Could you maybe add the programming language to the deliverables? This might help to clarify a few things, for example I’m currently not sure how NFT Market will be implemented (UI, CLI, etc.).

Thanks David @Noc2.

I just updated the programming languages, the deliverables are developed on-chain so mainly Rust. The NFT marketplace deliverable logic is handled purely on-chain, we also will share the fully functional version through either Docker or UAT access.

So, just to double check: A front-end is not part of this deliverable only pallets, correct? (because you now added the programming language of the UI as well).

@justinphamnz
Copy link
Contributor Author

Looks good, but I have one more request: Could you maybe add the programming language to the deliverables? This might help to clarify a few things, for example I’m currently not sure how NFT Market will be implemented (UI, CLI, etc.).

Thanks David @Noc2.
I just updated the programming languages, the deliverables are developed on-chain so mainly Rust. The NFT marketplace deliverable logic is handled purely on-chain, we also will share the fully functional version through either Docker or UAT access.

So, just to double check: A front-end is not part of this deliverable only pallets, correct? (because you now added the programming language of the UI as well).

Yes, that's right. A front-end is not part of this deliverable. We can demonstrate the UI on Docker or give the team access to the UAT environment.

Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification. Works for me.

@Noc2 Noc2 added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels Nov 17, 2021
@Noc2 Noc2 requested a review from alxs November 17, 2021 14:07
@Noc2 Noc2 merged commit f8a604b into w3f:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants