-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: swap securtiy and securityDefinition in context file #937
Conversation
From today's TD telko we should check if this is just a typo: td:securityDefinitions --> td:security ? @sebastiankb will check this |
I believe that the file |
from today's TD call:
|
I see there were a lot of changes to these definitions as part of the render script (PR #951) as well. Do we have to rebase this now, and/or has the issue been dealt with already? |
from today's TD call:
|
So I'm trying to understand what's going on here. It looks like the definitions for "security" and "securityDefinitions" got munged together somehow. Right now, in the rendered spec, there is only "security", and its description is correct, but the type is wrong, it should be array of strings (or one string). And "securityDefinitions" is missing, but should be "Map of SecurityScheme". The thing is... the published spec at https://www.w3.org/TR/wot-thing-description/#thing is correct. So something broke it along the way. BTW I wanted to based my "additionalSchemas" proposal for "additionalResults" on the setup for "securityDefinitions" but... |
Also, I don't think the PR fixes the problem, the definitions under "ontology" and elsewhere seem to have gone AWOL. Although the PR may fix a problem. |
From today's TD call:
|
form today's TD call: @vcharpenay is this PR still relevant or can we close it? |
from today's TD call, PR is not relevant anymore. |
This PR will fix the bug #915.
There some open questions:
td:securityDefinitions
, nor in validation or security ttl file:@vcharpenay may I ask you to check this.