Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: swap securtiy and securityDefinition in context file #937

Closed
wants to merge 1 commit into from

Conversation

sebastiankb
Copy link
Contributor

This PR will fix the bug #915.

There some open questions:

  • Why do we have two context files, td-context-1.1.jsonld and td-context.jsonld?
  • There seems no definition for td:securityDefinitions, nor in validation or security ttl file:

image

@vcharpenay may I ask you to check this.

@sebastiankb
Copy link
Contributor Author

sebastiankb commented Jul 29, 2020

From today's TD telko we should check if this is just a typo: td:securityDefinitions --> td:security ?

@sebastiankb will check this

@danielpeintner
Copy link
Contributor

I believe that the file context/td-context-1.1.jsonld is a merge from several other files like context/td-context.jsonld

@sebastiankb
Copy link
Contributor Author

from today's TD call:

@sebastiankb sebastiankb marked this pull request as draft September 16, 2020 15:14
@mmccool
Copy link
Contributor

mmccool commented Sep 19, 2020

I see there were a lot of changes to these definitions as part of the render script (PR #951) as well. Do we have to rebase this now, and/or has the issue been dealt with already?

@sebastiankb
Copy link
Contributor Author

from today's TD call:

  • not ready to merge
  • @vcharpenay how much time do you need to fix this issue (if possible)?

Base automatically changed from master to main February 24, 2021 15:22
@mmccool
Copy link
Contributor

mmccool commented Mar 23, 2021

So I'm trying to understand what's going on here. It looks like the definitions for "security" and "securityDefinitions" got munged together somehow. Right now, in the rendered spec, there is only "security", and its description is correct, but the type is wrong, it should be array of strings (or one string). And "securityDefinitions" is missing, but should be "Map of SecurityScheme". The thing is... the published spec at https://www.w3.org/TR/wot-thing-description/#thing is correct. So something broke it along the way.

BTW I wanted to based my "additionalSchemas" proposal for "additionalResults" on the setup for "securityDefinitions" but...

@mmccool
Copy link
Contributor

mmccool commented Mar 23, 2021

Also, I don't think the PR fixes the problem, the definitions under "ontology" and elsewhere seem to have gone AWOL. Although the PR may fix a problem.

@sebastiankb
Copy link
Contributor Author

sebastiankb commented May 5, 2021

From today's TD call:

@sebastiankb
Copy link
Contributor Author

form today's TD call: @vcharpenay is this PR still relevant or can we close it?

@sebastiankb
Copy link
Contributor Author

from today's TD call, PR is not relevant anymore.

@egekorkan egekorkan deleted the errata-context branch April 20, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants