Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BACnet protocol binding improvements #318

Merged
merged 10 commits into from
Nov 28, 2023
Merged

BACnet protocol binding improvements #318

merged 10 commits into from
Nov 28, 2023

Conversation

fennibay
Copy link
Contributor

  • Fix consistency issues between html, json schema and ttl
  • Make CommandPriority and CovIncrement complete URI variables
  • Remove covPeriod: This cannot be influenced from TD at all
  • Add remark on expected changes in TD.next (ref URI Variable for BACnet #302)

I also took over some changes from #309.

@fennibay
fix: remove bacnet:covPeriod
63517c8 
COV period is on the BACnet object, it cannot be influenced on the TD or on the BACnet service request.
And it is only supported on the Pulse Converter object, so it is not commonly found.
@fennibay
refactor: clean up services and URI variables
fac5e7e 
Make services consistent in html, ttl and JSON schema
Convert CovIncrement and CommandPriority to classes, for referencing via @type
Make  CovIncrement and CommandPriority fully URI variables. BACnet-conformance to Q.8 to be clarified.
@fennibay
fix: cleanup the examples with updated URI variables
1b41e4f
@fennibay
update the documentation on URI variables
5db4a5d
@fennibay
add remark on expected changes in TD.next
d99ec0d
@fennibay
fix: correct domain of bacv:usesService
d43fdae
@fennibay
fix: change logicalVal and protocolVal to has...
7c6e7b7
@fennibay
change the reference about Q.8 to "based on"
74ce248 
Because we are extending it with URI variables
@fennibay fennibay requested a review from egekorkan November 17, 2023 16:47
@netlify Netlify
Copy link

netlify bot commented Nov 17, 2023 •
edited
Loading

✅ Deploy Preview for wot-binding-templates ready!

Name Link
🔨 Latest commit a631eb8
🔍 Latest deploy log https://app.netlify.com/sites/wot-binding-templates/deploys/6565c38c8bcc5000082c30e9
😎 Deploy Preview https://deploy-preview-318--wot-binding-templates.netlify.app/bindings/protocols/bacnet
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@egekorkan
Copy link
Contributor

TD Call 22.11: @fennibay will cleanup the URI Scheme and then we can merge the PR asynchronously. He will also remove the draft from the name

@fennibay fennibay changed the title Draft: BACnet protocol binding improvements BACnet protocol binding improvements Nov 28, 2023
egekorkan
egekorkan approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@egekorkan egekorkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks @fennibay . As agreed in the call last week, we will merge this asynchronously.

@egekorkan egekorkan merged commit f5a7ec3 into main Nov 28, 2023
@egekorkan egekorkan deleted the fix/bacnet_cleanup branch November 28, 2023 14:52
@egekorkan egekorkan mentioned this pull request Nov 29, 2023
Closed
@ektrah ektrah added the bacnet related to bacnet protocol binding label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjkoster mjkoster mjkoster left review comments

@danielpeintner danielpeintner danielpeintner left review comments

@egekorkan egekorkan egekorkan approved these changes

@ektrah ektrah Awaiting requested review from ektrah ektrah is a code owner

Assignees
No one assigned
Labels
bacnet related to bacnet protocol binding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fennibay @egekorkan @mjkoster @danielpeintner @ektrah