Prune createAnswer()'s encodings and [[SendEncodings]] in sLD(answer). #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@docfaraday PTAL |
jan-ivar
commented
Dec 1, 2022
alvestrand
reviewed
Dec 8, 2022
jan-ivar
commented
Dec 8, 2022
|
Needs amendment file update. |
|
This issue was mentioned in WEBRTCWG-2023-01-17 (Page 11) |
23 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #2758 whose intent was to defer pruning of [[SendEncodings]] to sLD(answer), but mistakenly relied on the spec's existing pruning language which only applies to sRD(answer).
This adds similar language to sLD(answer), and fixes createAnswer() to direct JSEP on what to prune so pruning actually happens.
Preview | Diff