Do all input validation upfront in setConfiguration. #2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi @docfaraday |
dontcallmedom
added a commit
to dontcallmedom/web-platform-tests
that referenced
this pull request
Nov 15, 2023
Ensure that an invalid rtcconfiguration doesn't get partially applied
dontcallmedom
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 15, 2023
* Add test for w3c/webrtc-pc#2689 Ensure that an invalid rtcconfiguration doesn't get partially applied * Fix typo Co-authored-by: Harald Alvestrand <[email protected]> --------- Co-authored-by: Harald Alvestrand <[email protected]>
23 tasks
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 22, 2023
Automatic update from web-platform-tests Add test for w3c/webrtc-pc#2689 (#43167) * Add test for w3c/webrtc-pc#2689 Ensure that an invalid rtcconfiguration doesn't get partially applied * Fix typo Co-authored-by: Harald Alvestrand <[email protected]> --------- Co-authored-by: Harald Alvestrand <[email protected]> -- wpt-commits: 967eaa031cfe4039a18a7380899dbe3091d16cbe wpt-pr: 43167
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 22, 2023
Automatic update from web-platform-tests Add test for w3c/webrtc-pc#2689 (#43167) * Add test for w3c/webrtc-pc#2689 Ensure that an invalid rtcconfiguration doesn't get partially applied * Fix typo Co-authored-by: Harald Alvestrand <[email protected]> --------- Co-authored-by: Harald Alvestrand <[email protected]> -- wpt-commits: 967eaa031cfe4039a18a7380899dbe3091d16cbe wpt-pr: 43167
vinnydiehl
pushed a commit
to vinnydiehl/mozilla-unified
that referenced
this pull request
Nov 24, 2023
Automatic update from web-platform-tests Add test for w3c/webrtc-pc#2689 (#43167) * Add test for w3c/webrtc-pc#2689 Ensure that an invalid rtcconfiguration doesn't get partially applied * Fix typo Co-authored-by: Harald Alvestrand <[email protected]> --------- Co-authored-by: Harald Alvestrand <[email protected]> -- wpt-commits: 967eaa031cfe4039a18a7380899dbe3091d16cbe wpt-pr: 43167
vinnydiehl
pushed a commit
to vinnydiehl/mozilla-unified
that referenced
this pull request
Nov 24, 2023
Automatic update from web-platform-tests Add test for w3c/webrtc-pc#2689 (#43167) * Add test for w3c/webrtc-pc#2689 Ensure that an invalid rtcconfiguration doesn't get partially applied * Fix typo Co-authored-by: Harald Alvestrand <[email protected]> --------- Co-authored-by: Harald Alvestrand <[email protected]> -- wpt-commits: 967eaa031cfe4039a18a7380899dbe3091d16cbe wpt-pr: 43167
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Nov 30, 2023
Automatic update from web-platform-tests Add test for w3c/webrtc-pc#2689 (#43167) * Add test for w3c/webrtc-pc#2689 Ensure that an invalid rtcconfiguration doesn't get partially applied * Fix typo Co-authored-by: Harald Alvestrand <hta+githubalvestrand.no> --------- Co-authored-by: Harald Alvestrand <hta+githubalvestrand.no> -- wpt-commits: 967eaa031cfe4039a18a7380899dbe3091d16cbe wpt-pr: 43167 UltraBlame original commit: 85834bf43183a95724d1cb506f4bab06001cec6f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Nov 30, 2023
Automatic update from web-platform-tests Add test for w3c/webrtc-pc#2689 (#43167) * Add test for w3c/webrtc-pc#2689 Ensure that an invalid rtcconfiguration doesn't get partially applied * Fix typo Co-authored-by: Harald Alvestrand <hta+githubalvestrand.no> --------- Co-authored-by: Harald Alvestrand <hta+githubalvestrand.no> -- wpt-commits: 967eaa031cfe4039a18a7380899dbe3091d16cbe wpt-pr: 43167 UltraBlame original commit: 85834bf43183a95724d1cb506f4bab06001cec6f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Nov 30, 2023
Automatic update from web-platform-tests Add test for w3c/webrtc-pc#2689 (#43167) * Add test for w3c/webrtc-pc#2689 Ensure that an invalid rtcconfiguration doesn't get partially applied * Fix typo Co-authored-by: Harald Alvestrand <hta+githubalvestrand.no> --------- Co-authored-by: Harald Alvestrand <hta+githubalvestrand.no> -- wpt-commits: 967eaa031cfe4039a18a7380899dbe3091d16cbe wpt-pr: 43167 UltraBlame original commit: 85834bf43183a95724d1cb506f4bab06001cec6f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2688.
Preview | Diff