Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates in response to Issue #131 #132

Closed
wants to merge 1 commit into from

Conversation

awkawk
Copy link
Member

@awkawk awkawk commented Jan 8, 2016

No description provided.

@@ -30,8 +30,9 @@ a span {
height: 1px;
width: 1px;
position: absolute;
clip: rect(0 0 0 0);
margin: -1px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of the negative margin?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This thread discusses it: h5bp/html5-boilerplate#194 (in short, to avoid an errant single pixel of an item with a background color)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That can be solved with background: none|transparent; right?

—Michiel

On 11 Jan 2016, at 01:00, Andrew Kirkpatrick [email protected] wrote:

In wcag20/sources/techniques/css/C7.xml:

@@ -30,8 +30,9 @@ a span {
height: 1px;
width: 1px;
position: absolute;
+clip: rect(0 0 0 0);
+margin: -1px;
This thread discusses it: h5bp/html5-boilerplate#194 (in short, to avoid an errant single pixel of an item with a background color)


Reply to this email directly or view it on GitHub.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose so, I haven't seen that done or tested. One line of CSS either way?

@mraccess77
Copy link

Shouldn't we also add an overflow:hidden; ? also perhaps an !important after the position absolute?

@ZoeBijl
Copy link

ZoeBijl commented Jan 9, 2016

My original proposal included overflow hidden. Important should be avoided at all cost, what if you want to enable the text/element on smaller/larger screens; don't want to litter your css with a bunch of important's.

—Michiel

On 09 Jan 2016, at 03:13, Jonathan Avila [email protected] wrote:

Shouldn't we also add an overflow:hidden; ? also perhaps an !important after the position absolute?


Reply to this email directly or view it on GitHub.

@awkawk
Copy link
Member Author

awkawk commented Jan 11, 2016

Jon, overflow:hidden was in there before and wasn't removed.

@patrickhlauke patrickhlauke deleted the Issue131_patch branch September 16, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants