Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display 'Needs translation' on live website #108

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

remibetin
Copy link
Member

@remibetin remibetin commented Sep 26, 2024

Hides “Needs translation” on live website when a UI term is not translated: it clutters pages and is not useful to readers. (+ language markup is ok).

“Needs translation” would still be displayed on local and Netlify previews.

Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for wai-website-theme ready!

Name Link
🔨 Latest commit fe28e69
🔍 Latest deploy log https://app.netlify.com/sites/wai-website-theme/deploys/66f52b8ec1d3b90008960954
😎 Deploy Preview https://deploy-preview-108--wai-website-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@remibetin remibetin marked this pull request as ready for review October 8, 2024 12:08
@remibetin remibetin merged commit 4da3547 into main Oct 22, 2024
5 checks passed
@remibetin remibetin deleted the terms-to-translate branch October 22, 2024 16:18
@remibetin
Copy link
Member Author

Agreed with @shawna-slh today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant