Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream Trusted Types integration with SVGAnimatedString #934

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

lukewarlow
Copy link
Member

@lukewarlow lukewarlow commented Mar 20, 2024

This PR upstreams the trusted types integration with SVGAnimatedString. See https://www.w3.org/TR/trusted-types/#integration-with-svg

@caribouW3
Copy link
Member

It would be good to have a publish version of the trusted types spec instead of an editor's draft.

@caribouW3 caribouW3 marked this pull request as draft March 20, 2024 14:27
Copy link
Member

@caribouW3 caribouW3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to a /TR version rather than an editor's draft.

@lukewarlow lukewarlow marked this pull request as ready for review March 20, 2024 14:56
@caribouW3 caribouW3 merged commit 6d756e8 into w3c:main Mar 20, 2024
1 check passed
@lukewarlow lukewarlow deleted the trusted-types branch March 20, 2024 15:02
lukewarlow added a commit to lukewarlow/trusted-types that referenced this pull request Mar 20, 2024
lukewarlow added a commit to lukewarlow/trusted-types that referenced this pull request Mar 25, 2024
lukewarlow added a commit to w3c/trusted-types that referenced this pull request Mar 25, 2024
@lukewarlow
Copy link
Member Author

@caribouW3 this doesn't appear to be updated in https://svgwg.org/svg2-draft/types.html#InterfaceSVGAnimatedString

Does this just need publishing or have I missed something in this PR that I need to change?

@caribouW3
Copy link
Member

I believe that the scripts at svgwg.org are not picking the main branch.
W3C does not own that server, I can't fix this, unfortunately.

fred-wang added a commit to web-platform-tests/wpt that referenced this pull request Jan 13, 2025
This test is intended to cover setting href [1] [2] but it also
currently verifies some (currently not specified) unrelated behavior
when setting the text of the script via innerHTML. A similar test exist
in block-text-node-insertion-into-svg-script-element.html, but for a
disconnected script. This PR just move the unrelated test to
trusted-types-svg-script.html instead.

[1] w3c/svgwg#934
[2] whatwg/dom#1268
fred-wang added a commit to web-platform-tests/wpt that referenced this pull request Jan 13, 2025
…50043)

* Remove unrelated checks from trusted-types-svg-script-set-href.html

This test is intended to cover setting href [1] [2] but it also
currently verifies some (currently not specified) unrelated behavior
when setting the text of the script via innerHTML. A similar test exist
in block-text-node-insertion-into-svg-script-element.html, but for a
disconnected script. This PR just move the unrelated test to
trusted-types-svg-script.html instead.

[1] w3c/svgwg#934
[2] whatwg/dom#1268
sadym-chromium pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 14, 2025
…50043)

* Remove unrelated checks from trusted-types-svg-script-set-href.html

This test is intended to cover setting href [1] [2] but it also
currently verifies some (currently not specified) unrelated behavior
when setting the text of the script via innerHTML. A similar test exist
in block-text-node-insertion-into-svg-script-element.html, but for a
disconnected script. This PR just move the unrelated test to
trusted-types-svg-script.html instead.

[1] w3c/svgwg#934
[2] whatwg/dom#1268
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jan 15, 2025
…es-svg-script-set-href.html, a=testonly

Automatic update from web-platform-tests
Remove unrelated checks from trusted-types-svg-script-set-href.html (#50043)

* Remove unrelated checks from trusted-types-svg-script-set-href.html

This test is intended to cover setting href [1] [2] but it also
currently verifies some (currently not specified) unrelated behavior
when setting the text of the script via innerHTML. A similar test exist
in block-text-node-insertion-into-svg-script-element.html, but for a
disconnected script. This PR just move the unrelated test to
trusted-types-svg-script.html instead.

[1] w3c/svgwg#934
[2] whatwg/dom#1268

--

wpt-commits: 696792b6aa714c2d7c54b986814bbdbbdecf1dd8
wpt-pr: 50043
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Jan 16, 2025
…es-svg-script-set-href.html, a=testonly

Automatic update from web-platform-tests
Remove unrelated checks from trusted-types-svg-script-set-href.html (#50043)

* Remove unrelated checks from trusted-types-svg-script-set-href.html

This test is intended to cover setting href [1] [2] but it also
currently verifies some (currently not specified) unrelated behavior
when setting the text of the script via innerHTML. A similar test exist
in block-text-node-insertion-into-svg-script-element.html, but for a
disconnected script. This PR just move the unrelated test to
trusted-types-svg-script.html instead.

[1] w3c/svgwg#934
[2] whatwg/dom#1268

--

wpt-commits: 696792b6aa714c2d7c54b986814bbdbbdecf1dd8
wpt-pr: 50043

UltraBlame original commit: c08a3d36866a0421ce1e7f511543715b7a9c1b38
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Jan 16, 2025
…es-svg-script-set-href.html, a=testonly

Automatic update from web-platform-tests
Remove unrelated checks from trusted-types-svg-script-set-href.html (#50043)

* Remove unrelated checks from trusted-types-svg-script-set-href.html

This test is intended to cover setting href [1] [2] but it also
currently verifies some (currently not specified) unrelated behavior
when setting the text of the script via innerHTML. A similar test exist
in block-text-node-insertion-into-svg-script-element.html, but for a
disconnected script. This PR just move the unrelated test to
trusted-types-svg-script.html instead.

[1] w3c/svgwg#934
[2] whatwg/dom#1268

--

wpt-commits: 696792b6aa714c2d7c54b986814bbdbbdecf1dd8
wpt-pr: 50043

UltraBlame original commit: c08a3d36866a0421ce1e7f511543715b7a9c1b38
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Jan 16, 2025
…es-svg-script-set-href.html, a=testonly

Automatic update from web-platform-tests
Remove unrelated checks from trusted-types-svg-script-set-href.html (#50043)

* Remove unrelated checks from trusted-types-svg-script-set-href.html

This test is intended to cover setting href [1] [2] but it also
currently verifies some (currently not specified) unrelated behavior
when setting the text of the script via innerHTML. A similar test exist
in block-text-node-insertion-into-svg-script-element.html, but for a
disconnected script. This PR just move the unrelated test to
trusted-types-svg-script.html instead.

[1] w3c/svgwg#934
[2] whatwg/dom#1268

--

wpt-commits: 696792b6aa714c2d7c54b986814bbdbbdecf1dd8
wpt-pr: 50043

UltraBlame original commit: c08a3d36866a0421ce1e7f511543715b7a9c1b38
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request Jan 17, 2025
…es-svg-script-set-href.html, a=testonly

Automatic update from web-platform-tests
Remove unrelated checks from trusted-types-svg-script-set-href.html (#50043)

* Remove unrelated checks from trusted-types-svg-script-set-href.html

This test is intended to cover setting href [1] [2] but it also
currently verifies some (currently not specified) unrelated behavior
when setting the text of the script via innerHTML. A similar test exist
in block-text-node-insertion-into-svg-script-element.html, but for a
disconnected script. This PR just move the unrelated test to
trusted-types-svg-script.html instead.

[1] w3c/svgwg#934
[2] whatwg/dom#1268

--

wpt-commits: 696792b6aa714c2d7c54b986814bbdbbdecf1dd8
wpt-pr: 50043
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants