-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow remote playback device to choose the remote playback source. #141
Conversation
PTAL @mounirlamouri @jernoble |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if the behavior on remote playback end is implementation specific or not, so if we expect that to be standardized (versus the implementation-specific playback source selection mechanism) I'd like to see that in this document.
I think the note for 5.2.4 is fine as is.
LGTM. |
It seems @jernoble LGTM'd this PR conditional to @mounirlamouri's proposal #141 (comment) baked in? @mfoltzgoogle feel free to update the PR per the proposal and try to get quick confirmation from @mounirlamouri and/or @baylesj and @jernoble prior to merge. |
Updated the PR per the proposal from @mounirlamouri. I also moved a separate note regarding source selection to this part of the spec, so that all the discussion of source selection is now in this section. |
This addresses Issue #125: RemotePlaybackState enum can become misleading when changing media.src.
It clarifies that:
Some more clarification could be done:
.currentSrc
that was playing before remote playback was initiated.Let me know if you want further changes along these lines.
Preview | Diff