Markdown report: improve dfns, fix links, sort summary #1813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The markdown report now separates between dfns that are exported by default (such as CSS and Web IDL terms) and those that editors explicitly exported. Details only report on the explicitly exported terms both because they should be the most interesting ones to review, and because we don't want to create too long a report for usual specs, as GitHub imposes constraints to the length of an issue comment. This update sorts the summary to ease reading. The logic that handled links was also incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The markdown report now separates between dfns that are exported by default (such as CSS and Web IDL terms) and those that editors explicitly exported. Details only report on the explicitly exported terms both because they should be the most interesting ones to review, and because we don't want to create too long a report for usual specs, as GitHub imposes constraints to the length of an issue comment.
This update sorts the summary to ease reading.
The logic that handled links was also incorrect.