Wrap measureConversion return type in a dictionary for future extensions #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [SecureContext, Exposed=Window] | ||
| partial interface PrivateAttribution { | ||
| [Throws] Promise<Uint8Array> measureConversion(PrivateAttributionConversionOptions options); | ||
| [Throws] Promise<PrivateAttributionConversionResult> measureConversion(PrivateAttributionConversionOptions options); | ||
| }; | ||
| </xmp> |
There was a problem hiding this comment.
This probably needs more. We don't really describe the return value very well when describing the function, so maybe it is worth doing that down on line 666(old)/670(new) below.
There was a problem hiding this comment.
I agree, but we're already missing a lot of detail here. For example, Encrypt the report and Return the encrypted report do not explain how the Uint8Array is actually produced, so it might make more sense to fill that in later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85
Preview | Diff