Skip to content

Define type for stored impressions and use it in algorithms #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

Define type for stored impressions and use it in algorithms #74

merged 1 commit into from
Feb 20, 2025

Conversation

apasel422
Copy link
Collaborator

@apasel422 apasel422 commented Jan 30, 2025 •
edited by pr-preview bot
Loading

@apasel422 apasel422 marked this pull request as ready for review January 30, 2025 18:35
csharrison
csharrison reviewed Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@csharrison csharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of drive-bys for the existing code, feel free to clean them up now or in a follow-up.
Overall my preference is for each member to be well-typed.

@csharrison csharrison mentioned this pull request Feb 4, 2025
Merged
@apasel422 apasel422 mentioned this pull request Feb 4, 2025
Closed
@apasel422 apasel422 force-pushed the def branch 2 times, most recently from 19fc0a7 to 1d35588 Compare February 5, 2025 19:34
@apasel422 apasel422 requested a review from csharrison February 6, 2025 15:57
csharrison
csharrison approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@csharrison csharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martinthomson martinthomson merged commit 6bff814 into w3c:main Feb 20, 2025
1 check passed
@apasel422 apasel422 deleted the def branch February 20, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csharrison csharrison csharrison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apasel422 @csharrison @martinthomson