The common atttribute of PerformanceEntry should be initialized rat…
#210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her than inherited Other specs should initialize startTime/entry/name/endTime rather than provide overrides for them.
clelland
reviewed
Jan 22, 2024
|
@clelland care to review? |
noamr
commented
Feb 2, 2024
index.html
Outdated
|
|
||
| <ol> | ||
| <li>Assert: <var>entryType</var> is defined in the <a href="https://w3c.github.io/timing-entrytypes-registry/#registry">entry type registry</a>. | ||
| <li>Set <var>entry</var>'s <a>startTime</a> to <var>startTime</var>. |
clelland
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Oops, accidentally deleted that comment; didn't realize it had already been sent. The general idea I wanted to suggest was that we may want to make a general distinction in specs between a one-time 'initialization" vs a maybe-repeatable "set" operation. I don't know if this happens anywhere else, aside from the "initial values" we give to some properties.
Anyway, this LGTM, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…her than inherited
Other specs should initialize startTime/entry/name/endTime rather than provide overrides for them.
💥 Error: 502 Bad Gateway 💥
PR Preview failed to build. (Last tried on Feb 2, 2024, 2:45 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.