Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add redactList for PaymentAddress (Part 1) #654

Merged
merged 35 commits into from
Mar 15, 2018
Merged

add redactList for PaymentAddress (Part 1) #654

Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
a10bb08
WIP: make PaymentAddress constructable
marcoscaceres Nov 20, 2017
5d1a35b
Address review feedback, contruct from dict
marcoscaceres Dec 6, 2017
8a4cbd8
fix typo
marcoscaceres Dec 6, 2017
124686f
Link strip and collapse ws
marcoscaceres Dec 6, 2017
b25a4d8
More WIP
marcoscaceres Dec 7, 2017
af7c9d7
typo
marcoscaceres Dec 7, 2017
db19219
Mandate phone numbers adhere to E.164 (closes #652)
marcoscaceres Dec 8, 2017
1101a7f
Editorial cleanup
marcoscaceres Dec 8, 2017
4b16b63
Relocated user-created address algo
marcoscaceres Dec 8, 2017
54a10eb
Link to enum value defintions
marcoscaceres Dec 8, 2017
92e04c7
Address privacy of post codes
marcoscaceres Dec 8, 2017
d7de7d4
Feat: add regionCode attribute and member
marcoscaceres Jan 24, 2018
76c8baa
review feedback
marcoscaceres Feb 13, 2018
d5d455f
make constructor internal
marcoscaceres Feb 27, 2018
4501c4d
tidy
marcoscaceres Feb 27, 2018
799a719
Make exclude list values optional
marcoscaceres Feb 27, 2018
66b9a3b
Not possible for devs to represent addresses
marcoscaceres Feb 27, 2018
10923f5
Remove AddressField enum
marcoscaceres Feb 27, 2018
24ff121
Remove phone number algos
marcoscaceres Feb 27, 2018
1f0d0e4
nit
marcoscaceres Feb 27, 2018
0378ab5
Relocate recipient format details
marcoscaceres Feb 27, 2018
67f4e7a
nits
marcoscaceres Feb 27, 2018
6f751d7
Editorial improvements
marcoscaceres Feb 27, 2018
f5ff02e
remove regionCode
marcoscaceres Feb 28, 2018
31428e7
s/excludeList/redactList
marcoscaceres Mar 6, 2018
1807bf4
Review nits/typos
marcoscaceres Mar 7, 2018
358f08b
fix construction details
marcoscaceres Mar 7, 2018
82eee2e
trim things
marcoscaceres Mar 7, 2018
d032e25
Add privacy note about redactList
marcoscaceres Mar 8, 2018
30e6806
assure request+response use same shippingAddress
marcoscaceres Mar 8, 2018
a7e615b
fix respec warning
marcoscaceres Mar 8, 2018
f968a0c
tidy
marcoscaceres Mar 8, 2018
50f6cdd
If not shipping, response address is null
marcoscaceres Mar 8, 2018
331280c
Review feedback
marcoscaceres Mar 14, 2018
e21719c
fix: typo
marcoscaceres Mar 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Not possible for devs to represent addresses
  • Loading branch information
@marcoscaceres
marcoscaceres committed Mar 15, 2018
commit 66b9a3bb4c744b5ae1b821383800ab757d13c2e9
4 changes: 0 additions & 4 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1996,10 +1996,6 @@ <h2>
<p>
A <dfn>physical address</dfn> is composed of the following concepts.
</p>
<p class="note">
Developers wanting to represent a <a>physical address</a> can use the
<a>PaymentAddress</a> interface.
</p>
<dl data-sort="">
<dt>
<dfn>Country</dfn>
Expand Down