Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the agent fingerprint as the SPKI. #301

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Conversation

markafoltz
Copy link
Contributor

@markafoltz markafoltz commented Sep 10, 2022

Addresses Issue #282: Certificates should have a maximum lifetime, and SPAKE2 identities should be SPKI not cert fingerprint

This defines the agent fingerprint in terms of the SPKI (e.g., the public key) of the agent certificate. The agent fingerprint is used to identify agents and is input to SPAKE2.

This allows agents to use shorter-lived certificates and renew their certificates without having to re-authenticate to other agents.

This PR does not specify certificate lifetimes or renewal policies. It also does not handle the issuing of completely new certificates while maintaining previous trust relationships.


Preview | Diff

@markafoltz
Copy link
Contributor Author

This should address the issues raised in #282, while overall certificate management needs more discussion.

@markafoltz markafoltz requested a review from baylesj September 6, 2023 20:19
@markafoltz
Copy link
Contributor Author

@baylesj to take a look.

@markafoltz markafoltz added v1-spec security-tracker Group bringing to attention of security, or tracked by the security Group but not needing response. labels Sep 11, 2023
Copy link
Contributor

@baylesj baylesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % feedback.

@markafoltz
Copy link
Contributor Author

@backkem, this PR uses the SPKI as defined in RFC 7469, but thank you for the earlier PR :-)

@markafoltz
Copy link
Contributor Author

@baylesj, PTAL

@markafoltz markafoltz merged commit ca83371 into main Feb 28, 2024
2 checks passed
@markafoltz markafoltz deleted the issue-282-spki-3 branch February 28, 2024 17:40
@markafoltz
Copy link
Contributor Author

Went and merged this as I believe the last comments are addressed. Please let me know if there are additional comments @baylesj

github-actions bot added a commit that referenced this pull request Feb 28, 2024
SHA: ca83371
Reason: push, by mfoltzgoogle

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F2F security-tracker Group bringing to attention of security, or tracked by the security Group but not needing response. v1-spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certificates should have a maximum lifetime, and SPAKE2 identities should be SPKI not cert fingerprint
2 participants