Skip to content

Commit

Permalink
travis needs special setup for jdk9-ea beta
Browse files Browse the repository at this point in the history 
see travis-ci/travis-ci#5520 (comment)
  • Loading branch information
@tofi86
tofi86 committed Sep 17, 2017
1 parent 3c33796 commit df88577
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .travis.yml
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
language: java
sudo: required
dist: precise
group: edge
jdk:
- oraclejdk9
- oraclejdk8
Expand Down

4 comments on commit df88577

@h3xstream
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tofi86 I attempt to reproduce this configuration. It doesn't seem to work on my side. Do you have any hints? find-sec-bugs/find-sec-bugs@1680d19

@tofi86
Copy link
Collaborator Author

@tofi86 tofi86 commented on df88577 Mar 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this isn't needed anymore. Have a look at the .travis.yml at the current master branch, it only references the jdk: - oraclejdk9.

This commit here was part of the PullRequest, but was reverted or overwritten while finalizing PR #766.

Seems to work out of the box now without sudo, dist, group keys...

@tofi86
Copy link
Collaborator Author

@tofi86 tofi86 commented on df88577 Mar 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, oraclejdk9 is now officialy mentioned in the travis docs:
https://docs.travis-ci.com/user/languages/java/#Testing-Against-Multiple-JDKs

This wasn't the case when I wrote these changes for PR #766

@h3xstream
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tofi86 Thanks for the reply. I will continue to investigate.

Please sign in to comment.