Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid or identical colors provided to backColor/foreColor/hiliteColor should return true instead of false #476

Open
gmta opened this issue Jan 23, 2025 · 0 comments
Open

Invalid or identical colors provided to backColor/foreColor/hiliteColor should return true instead of false #476

gmta opened this issue Jan 23, 2025 · 0 comments

Comments

@gmta
Copy link

gmta commented Jan 23, 2025

If the value string provided to backColor, foreColor or hiliteColor is either an invalid CSS color or the current color, the spec states to return false:

editing/docs/execCommand/index.html

Lines 4201 to 4202 in b9fbe88

<li>If <var title="">value</var> is still not a valid CSS color, or
if it is currentColor, return false.

As tested in both Firefox and Chrome, we should instead return true here.
gmta added a commit to gmta/ladybird that referenced this issue Jan 24, 2025
@gmta
LibWeb: Return true if invalid color was provided to an editing command
abeb6ac 
Both Chrome and Firefox return `true` whenever the value string provided
is an invalid color or the current color. Spec issue raised:

  w3c/editing#476
gmta added a commit to gmta/ladybird that referenced this issue Jan 24, 2025
@gmta
LibWeb: Return true if invalid color was provided to an editing command
ae0418f 
Both Chrome and Firefox return `true` whenever the value string provided
is an invalid color or the current color. Spec issue raised:

  w3c/editing#476
gmta added a commit to gmta/ladybird that referenced this issue Jan 24, 2025
@gmta
LibWeb: Return true if invalid color was provided to an editing command
dedbbb7 
Both Chrome and Firefox return `true` whenever the value string provided
is an invalid color or the current color. Spec issue raised:

  w3c/editing#476
gmta added a commit to gmta/ladybird that referenced this issue Jan 24, 2025
@gmta
LibWeb: Return true if invalid color was provided to an editing command
fa4db4d 
Both Chrome and Firefox return `true` whenever the value string provided
is an invalid color or the current color. Spec issue raised:

  w3c/editing#476
awesomekling pushed a commit to LadybirdBrowser/ladybird that referenced this issue Jan 24, 2025
@gmta @awesomekling
LibWeb: Return true if invalid color was provided to an editing command
0c854f9 
Both Chrome and Firefox return `true` whenever the value string provided
is an invalid color or the current color. Spec issue raised:

  w3c/editing#476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gmta