Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Media Feeds spec #99

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Add Media Feeds spec #99

merged 1 commit into from
Jun 17, 2020

Conversation

dontcallmedom
Copy link
Member

Has an implementation in Chrome behind a flag https://www.chromestatus.com/features/5695114963845120

this should probably be handled similarly to our approach to #86

@dontcallmedom dontcallmedom requested review from foolip and tidoust June 17, 2020 13:27
@dontcallmedom dontcallmedom mentioned this pull request Jun 17, 2020
Closed
69 tasks
tidoust
tidoust approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@tidoust tidoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, that may still be a tad early, but the incubation seems to be progressing quite fast.

@tidoust tidoust merged commit 8a8fdef into master Jun 17, 2020
@dontcallmedom
Copy link
Member Author

I meant to refer to #87 not #86 (since it is behind a flag) - but merging it as is also wfm :)

@tidoust tidoust deleted the media-feeds branch July 1, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tidoust tidoust tidoust approved these changes

@foolip foolip Awaiting requested review from foolip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dontcallmedom @tidoust