Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add carousel pattern #957

Merged
merged 15 commits into from
Jan 15, 2019
Merged

Add carousel pattern #957

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e185d24
Carousel Pattern: draft 1 based on draft from Jon Gunderson
mcking65 Dec 12, 2018
5a0a681
Complete first draft of pattern description
mcking65 Dec 12, 2018
6cf4a4b
Revise keyboard interaction.
mcking65 Dec 13, 2018
f2c06f5
partial draft of roles, states, and props
mcking65 Dec 14, 2018
c473dc8
another draft of carousel roles, states, and props
mcking65 Dec 16, 2018
114d39d
another carousel props draft
mcking65 Dec 16, 2018
484bb8c
Another draft of props section of carousel
mcking65 Dec 16, 2018
e6e7f4d
Complete draft of carousel props section
mcking65 Dec 16, 2018
a33bcf2
minor carousel pattern edit
mcking65 Dec 16, 2018
c81e8b3
Changes from meeting feedback
mcking65 Dec 18, 2018
8856024
Fixes in response to review comments from @charmarkk
mcking65 Dec 18, 2018
60248e5
Add slide show to section title
mcking65 Dec 18, 2018
ee6154e
Revise description based on feedback from @jongund in issue #43.
mcking65 Dec 18, 2018
30e3806
Add guidance about rotation control position per feedback from @jongu…
mcking65 Dec 18, 2018
6f2f95e
Fix typo found by @annabbott in review.
mcking65 Jan 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add guidance about rotation control position per feedback from @jongund… 
… in issue #43.
  • Loading branch information
@mcking65
mcking65 committed Dec 18, 2018
commit 30e3806afa7b1bb1bf458883f3dfb709696f80ae
1 change: 1 addition & 0 deletions aria-practices.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,6 +541,7 @@ <h4>Keyboard Interaction</h4>
Button elements implement the keyboard interaction defined in the <a href="#button">button pattern</a>.
Note: Activating the rotation control, next slide, and previous slide do not move focus, so users may easily repetitively activate them as many times as desired.
</li>
<li>If present, the rotation control is the first element in the <kbd>Tab</kbd> sequence inside the carousel. It is essential that it precede the rotating content so it can be easily located.</li>
<li>If tab elements are used for slide picker controls, they implement the keyboard interaction defined in the <a href="#tabpanel">Tabs Pattern.</a></li>
</ul>
</section>
Expand Down