Add tests for disclosure/disclosure-faq.html #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tatermelon, @jessebeach, @sh0ji, this is ready for review. |
spectranaut
force-pushed
the
bocoup-disclosure-faq
branch
from
c0b7319 to
5e28051
Compare
spectranaut
changed the title
|
@spectranaut, looks like we are getting the session errors. I'm restarting the build another time to see if it happens again. |
jessebeach
approved these changes
Aug 28, 2018
|
|
||
| let buttons = await t.context.session.findElements(By.css(ex.buttonSelector)); | ||
| for (let button of buttons) { | ||
| await button.click(); |
There was a problem hiding this comment.
Huh, I thought having an await in a for..of loop would cause a problem, but the Iteration Protocol handles it automatically. Very readable, very nice.
| let answers = await t.context.session.findElements(By.css(ex.buttonSelector)); | ||
| for (let answer of answers) { | ||
| t.true( | ||
| await answer.isDisplayed(), |
There was a problem hiding this comment.
This might fail if true isn't asynchronous. Maybe pull the await to the line above, store the result and then call true with the variable as the first argument. If this pattern is prevalent, it might be a source of your timing issues.
| await button.sendKeys(Key.ENTER); | ||
|
|
||
| t.true( | ||
| await waitAndCheckExpandedTrue(t, button), |
There was a problem hiding this comment.
ditto to above and for all the rest below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests written, only blocking on acceptance of race condition PR: #837