Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Initial cSpell setup #841

Merged
merged 7 commits into from
Mar 3, 2020
Merged

build: Initial cSpell setup #841

merged 7 commits into from
Mar 3, 2020

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Aug 18, 2018 •
edited by pr-preview bot
Loading

Not all words have been excluded yet, but I figure I'd show the approach before going through everything.

Preview | Diff

nschonni
nschonni commented Aug 18, 2018
View reviewed changes
cspell.json Show resolved Hide resolved
@nschonni nschonni force-pushed the cspell-build branch 2 times, most recently from 4eae790 to 44cc71e Compare August 30, 2018 04:46
@nschonni
Copy link
Contributor Author

Green now. The spelling fixes could be pulled into separate PRs if this doesn't land

sh0ji
sh0ji reviewed Feb 25, 2019
View reviewed changes
Copy link
Contributor

@sh0ji sh0ji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @nschonni. Hopefully we can get this merged soon.

@mcking65, this currently won't check spelling on the root aria-practices.html (soon to be index.html). I assume it should check spelling there, but thought I'd check with you first.

@nschonni, could you also add an entry to the Travis tests for this that's allowed to fail? It's the kind of feedback that will be useful but shouldn't be blocking.

package.json Outdated Show resolved Hide resolved
@nschonni nschonni force-pushed the cspell-build branch 2 times, most recently from be031c3 to de579a0 Compare February 26, 2019 01:22
@sh0ji
Copy link
Contributor

sh0ji commented Mar 3, 2019

Last request: could you resolve the new Travis conflict and add ALLOW_FAILURE=true to make sure spelling errors won't be blocking?

Thanks for all your work on this, @nschonni!

@mcking65
Copy link
Contributor

mcking65 commented Apr 2, 2019

@nschonni, friendly ping about this request from Evan:

Last request: could you resolve the new Travis conflict and add ALLOW_FAILURE=true to make sure spelling errors won't be blocking?

Thanks for all your work on this, @nschonni!

@nschonni nschonni force-pushed the cspell-build branch 2 times, most recently from 9926bee to 49e504e Compare April 2, 2019 23:33
@nschonni nschonni closed this Apr 10, 2019
@nschonni nschonni reopened this Apr 10, 2019
@nschonni
Copy link
Contributor Author

@mcking65 @sh0ji it's rebased again. There are still a few things showing up in the results, but you can see the allowed failures works

@nschonni nschonni force-pushed the cspell-build branch 2 times, most recently from eb4fb30 to d1258cc Compare June 24, 2019 21:54
@nschonni
Copy link
Contributor Author

@mcking65 @sh0ji I've rebased and added the aria-practices.html to the checking

@nschonni nschonni mentioned this pull request Jun 26, 2019
Merged
@sh0ji
Copy link
Contributor

sh0ji commented Jun 28, 2019

LGTM! Thanks for sticking with this.

@nschonni
Copy link
Contributor Author

nschonni commented Jul 1, 2019

Rebased now that the spellcheck fixes PR landed separately

@nschonni
Copy link
Contributor Author

Rebased, but didn't fix the new spelling issues that are flagged

@nschonni
Copy link
Contributor Author

Remaining spelling fixes split out to #1223

@nschonni nschonni force-pushed the cspell-build branch 3 times, most recently from c7d6b12 to c03a2f9 Compare October 25, 2019 16:15
nschonni and others added 4 commits February 14, 2020 00:03
@nschonni @zcorpan
build: Initial cSpell setup
018108c
@nschonni @zcorpan
chore: Add Spelling to CI build
f0fb402
@nschonni @zcorpan
chore: Add cSpell VS Code extension suggestion
9169ced 
- All the workds in the settings.json are already in the dictionary
- Extension will be "recommended" when opening the workspace in VS Code
@zcorpan
Add more ignored words
69d2272
@zcorpan
Copy link
Member

zcorpan commented Feb 13, 2020

I've added more words to ignore and rebased on latest master to resolve conflicts with package*.json. There should be no misspelled words now, again.

@zcorpan
Copy link
Member

zcorpan commented Feb 13, 2020

I documented this in https://github.com/w3c/aria-practices/wiki/APG-Infrastructure#cspell

@ZoeBijl
Copy link
Contributor

ZoeBijl commented Feb 28, 2020

Is this dependent on anything/what needs to be done before this can be merged?

@mcking65
Copy link
Contributor

mcking65 commented Mar 3, 2020

I think we are good to go. I am curious to see how much it helps us. Our project may not be the best fit for this particular package.

@nschonni, I really appreciate all your support here!!

@mcking65 mcking65 merged commit 027d19e into w3c:master Mar 3, 2020
michael-n-cooper pushed a commit that referenced this pull request Mar 3, 2020
@zcorpan @ZoeBijl @mcking65
Generated by TRAVIS-CI 027d19e
a3ed6d4 
Infrastructure: Add cSpell to the build process (pull #841)

* build: Initial cSpell setup
* chore: Add Spelling to CI build
* chore: Add cSpell VS Code extension suggestion
* Extension will be "recommended" when opening the workspace in VS Code
* Add ignored words

Co-authored-by: Simon Pieters <[email protected]>
Co-authored-by: Zoë Bijl <[email protected]>
Co-authored-by: Matt King <[email protected]>
@nschonni nschonni deleted the cspell-build branch March 3, 2020 22:14
carmacleod pushed a commit to carmacleod/aria-practices that referenced this pull request Mar 31, 2020
@nschonni @zcorpan
@ZoeBijl @mcking65 @carmacleod
Infrastructure: Add cSpell to the build process (pull w3c#841)
38feee6 
* build: Initial cSpell setup
* chore: Add Spelling to CI build
* chore: Add cSpell VS Code extension suggestion
* Extension will be "recommended" when opening the workspace in VS Code
* Add ignored words

Co-authored-by: Simon Pieters <[email protected]>
Co-authored-by: Zoë Bijl <[email protected]>
Co-authored-by: Matt King <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh0ji sh0ji sh0ji left review comments

Assignees

@sh0ji sh0ji

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nschonni @sh0ji @mcking65 @zcorpan @ZoeBijl