-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling fixes #834
Spelling fixes #834
Conversation
Fixed JS comment block that was HTML
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please validate that all references to the idref cope with the change. It is likely a typo but I haven't looked at the code to see what impact a change like that would have.
@@ -18,7 +18,7 @@ <h1 id="outreach">Outreach</h1> | |||
<h2 id="comm-engage">Community Engagement</h2> | |||
<p><a href="menubar-1.html#code-ex-1">Back to <code>menubar</code> example</a></p> | |||
|
|||
<h2 id="copr-rel">Corporate Relations</h2> | |||
<h2 id="corp-rel">Corporate Relations</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure idrefs should be spellchecked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They can be indvidually ignored, but in this case there are no refs https://github.com/w3c/aria-practices/search?q=copr&unscoped_q=copr and it looked like a typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like we have some unnecessary files left over from old content in the menubar-1 folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree - looks like we can remove mb-research.html, mb-arts.html and mb-outreach.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in commit c57878b
@nschonni, thank you for all these fixes! Having integrated spell checking would be great. I don't know anything about cspell. Having to ignore ids individually sounds like serious pain ... makes me wonder if cspell is a good solution for our purposes. Seems like we would not want to spell check the values of any attributes except for perhaps aria-label. The validator will catch most any other attribute mistake. |
Spelling fixes (pull #834) Fixes 21 errors across 18 files. * typo: Transcripts * typo: attribute * typo: imitate * typo: Research * typo: performing * typo: Transcripts * typo: left * typo: arbitrary * typo: left * typo: corp * typo: parent * typo: selector * typo: parent * typo: selector * typo: accessible * typo: left * typo: relevant * Fixed JS comment block that was HTML * typo: shortcuts * typo: selector * typo: accessible * typo: information
Per comments in pull request #834, removed the following 3 html files that are no longer used by the navigation menubar example. deleted: examples/menubar/menubar-1/mb-arts.html deleted: examples/menubar/menubar-1/mb-outreach.html deleted: examples/menubar/menubar-1/mb-research.html
Navigation Menubar Example: delete 3 unused html files Per comments in pull request #834, removed the following 3 html files that are no longer used by the navigation menubar example. deleted: examples/menubar/menubar-1/mb-arts.html deleted: examples/menubar/menubar-1/mb-outreach.html deleted: examples/menubar/menubar-1/mb-research.html
Fixes 21 errors across 18 files. * typo: Transcripts * typo: attribute * typo: imitate * typo: Research * typo: performing * typo: Transcripts * typo: left * typo: arbitrary * typo: left * typo: corp * typo: parent * typo: selector * typo: parent * typo: selector * typo: accessible * typo: left * typo: relevant * Fixed JS comment block that was HTML * typo: shortcuts * typo: selector * typo: accessible * typo: information
Per comments in pull request w3c#834, removed the following 3 html files that are no longer used by the navigation menubar example. deleted: examples/menubar/menubar-1/mb-arts.html deleted: examples/menubar/menubar-1/mb-outreach.html deleted: examples/menubar/menubar-1/mb-research.html
Ran cspell to fix up some typos. Not entirely done, but I'll try and add it to the build with the config separately