Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling fixes #834

Merged
merged 21 commits into from
Aug 16, 2018
Merged

Spelling fixes #834

merged 21 commits into from
Aug 16, 2018

Conversation

nschonni
Copy link
Contributor

Ran cspell to fix up some typos. Not entirely done, but I'll try and add it to the build with the config separately

Copy link
Member

@jnurthen jnurthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please validate that all references to the idref cope with the change. It is likely a typo but I haven't looked at the code to see what impact a change like that would have.

@@ -18,7 +18,7 @@ <h1 id="outreach">Outreach</h1>
<h2 id="comm-engage">Community Engagement</h2>
<p><a href="menubar-1.html#code-ex-1">Back to <code>menubar</code> example</a></p>

<h2 id="copr-rel">Corporate Relations</h2>
<h2 id="corp-rel">Corporate Relations</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure idrefs should be spellchecked.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They can be indvidually ignored, but in this case there are no refs https://github.com/w3c/aria-practices/search?q=copr&unscoped_q=copr and it looked like a typo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we have some unnecessary files left over from old content in the menubar-1 folder.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree - looks like we can remove mb-research.html, mb-arts.html and mb-outreach.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in commit c57878b

@mcking65
Copy link
Contributor

@nschonni, thank you for all these fixes!

Having integrated spell checking would be great. I don't know anything about cspell. Having to ignore ids individually sounds like serious pain ... makes me wonder if cspell is a good solution for our purposes. Seems like we would not want to spell check the values of any attributes except for perhaps aria-label. The validator will catch most any other attribute mistake.

@mcking65 mcking65 merged commit 5e1978b into w3c:master Aug 16, 2018
michael-n-cooper pushed a commit that referenced this pull request Aug 16, 2018
Spelling fixes (pull #834)

Fixes 21 errors across 18 files.

* typo: Transcripts
* typo: attribute
* typo: imitate
* typo: Research
* typo: performing
* typo: Transcripts
* typo: left
* typo: arbitrary
* typo: left
* typo: corp
* typo: parent
* typo: selector
* typo: parent
* typo: selector
* typo: accessible
* typo: left
* typo: relevant
* Fixed JS comment block that was HTML
* typo: shortcuts
* typo: selector
* typo: accessible
* typo: information
mcking65 added a commit that referenced this pull request Aug 17, 2018
Per comments in pull request #834, removed the following 3 html files that are no longer  used by the navigation menubar example.
deleted:    examples/menubar/menubar-1/mb-arts.html
deleted:    examples/menubar/menubar-1/mb-outreach.html
deleted:    examples/menubar/menubar-1/mb-research.html
michael-n-cooper pushed a commit that referenced this pull request Aug 17, 2018
Navigation Menubar Example: delete 3 unused html files

Per comments in pull request #834, removed the following 3 html files that are no longer  used by the navigation menubar example.
deleted:    examples/menubar/menubar-1/mb-arts.html
deleted:    examples/menubar/menubar-1/mb-outreach.html
deleted:    examples/menubar/menubar-1/mb-research.html
spectranaut pushed a commit to bocoup/aria-practices that referenced this pull request Aug 27, 2018
Fixes 21 errors across 18 files.

* typo: Transcripts
* typo: attribute
* typo: imitate
* typo: Research
* typo: performing
* typo: Transcripts
* typo: left
* typo: arbitrary
* typo: left
* typo: corp
* typo: parent
* typo: selector
* typo: parent
* typo: selector
* typo: accessible
* typo: left
* typo: relevant
* Fixed JS comment block that was HTML
* typo: shortcuts
* typo: selector
* typo: accessible
* typo: information
spectranaut pushed a commit to bocoup/aria-practices that referenced this pull request Aug 27, 2018
Per comments in pull request w3c#834, removed the following 3 html files that are no longer  used by the navigation menubar example.
deleted:    examples/menubar/menubar-1/mb-arts.html
deleted:    examples/menubar/menubar-1/mb-outreach.html
deleted:    examples/menubar/menubar-1/mb-research.html
@nschonni nschonni deleted the spelling branch August 19, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants