Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinbutton Pattern: Add aria-invalid guidance for values outside allowed range #825

Merged
merged 2 commits into from
Aug 29, 2018

Conversation

mcking65
Copy link
Contributor

@mcking65 mcking65 commented Aug 6, 2018

In response to issue #704, modified the roles, states, and properties section of the spinbutton pattern in aria-practices.html.

Adds a bullet to the list of roles, states, and properties stating that aria-invalid is set true if it is possible for the textbox to contain a value that is not allowed.


Preview | Diff

…owed range

In response to issue #704, modified the roles, states, and properties section of the spinbutton pattern in aria-practices.html.

Added a bullet to the list of roles, states, and properties stating that aria-invalid is set true if it is possible for the textbox to contain a value that is not allowed.
@0ddfell0w
Copy link

Thanks for the change, my only note is that the wording could be misconstrued (with some effort) to be saying "if an invalid state is possible then set aria-invalid to true" as opposed to "For spinbuttons that allow users to enter invalid inputs, set aria-invalid to true when the value is invalid."

For issue #704, per feedback from @0ddfell0w, changed wording of guidance.
@mcking65
Copy link
Contributor Author

@0ddfell0w, Commit 02bb24f changes the wording to:

The spinbutton element has aria-invalid set to true if the value is outside the allowed range. Note that most implementations prevent input of invalid values, but in some scenarios, blocking all invalid input may not be practical.

@charmarkk
Copy link
Contributor

This looks good to me Matt! -Mark

@ZoeBijl
Copy link
Contributor

ZoeBijl commented Aug 27, 2018

How about something like this:

Most spinbutton implementations will prevent the input of invalid values. But, in some cases blocking invalid input might not be practical. In such scenarios aria-invalid is set to true if the value is outside of the allowed range.

This is pretty close to how I’d write it in an article or some such. I think I kept the information the same and only changed the tone slightly.

@ZoeBijl ZoeBijl changed the title Sppinbutton Pattern: Add aria-invalid guidance for values outside allowed range Spinbutton Pattern: Add aria-invalid guidance for values outside allowed range Aug 27, 2018
@mcking65 mcking65 merged commit 4992388 into master Aug 29, 2018
michael-n-cooper pushed a commit that referenced this pull request Aug 29, 2018
Spin Button Pattern: Add aria-invalid guidance for values outside allowed range (pull #825)

In response to issue #704, modified the roles, states, and properties section of the spin button pattern in aria-practices.html.

Added a bullet to the list of roles, states, and properties stating that aria-invalid is set true if it is possible for the textbox to contain a value that is not allowed.
@mcking65 mcking65 deleted the issue704-spinbutton-value branch December 18, 2018 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants