Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Example using Button: Fix white on white bug #2482

Merged
merged 6 commits into from
Oct 4, 2022
Merged

Switch Example using Button: Fix white on white bug #2482

merged 6 commits into from
Oct 4, 2022

Conversation

jongund
Copy link
Contributor

@jongund jongund commented Sep 26, 2022 •
edited
Loading

@jongund jongund changed the title updated the css to set button text color and SVG stroke color Updated switch example using Button and SVG Sep 26, 2022
@jongund jongund linked an issue Sep 27, 2022 that may be closed by this pull request
Switch example using HTML button clashes with website CSS #2474
Closed
jnurthen
jnurthen approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@jnurthen jnurthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alflennik
alflennik approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@alflennik alflennik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@mcking65 mcking65 changed the title Updated switch example using Button and SVG Switch Example using Button: Fix white on white bug Oct 4, 2022
@mcking65 mcking65 merged commit c934c22 into main Oct 4, 2022
@mcking65 mcking65 deleted the fix-switch-example branch October 4, 2022 22:45
@mcking65
Copy link
Contributor

mcking65 commented Oct 4, 2022

@s3ththompson

This commit is ready to be added to the publication branch.

Note that @a11ydoer is working on another PR that we'd also like to include in publication this week if we can get it ready in time. She is still drafting.

@mcking65
Copy link
Contributor

mcking65 commented Oct 4, 2022

Thank you @jongund for the fix!!

@a11ydoer
Copy link
Contributor

a11ydoer commented Oct 5, 2022

@s3ththompson @mcking65 @alflennik
I forgot to create the branch and committed the change directly to main branch....do you want me to create the branch and create PR?

@s3ththompson s3ththompson mentioned this pull request Oct 7, 2022
Merged
alflennik pushed a commit that referenced this pull request Oct 20, 2022
@jongund @alflennik
Switch Example using Button: Fix white on white bug (Pull #2482)
e650074 
Fix #2474, which resulted in the switch being displayed as white on white, by:
* updating the css to set button text color and SVG stroke color
* changing button height
* removing stroke color specification
@alflennik
Copy link
Contributor

These changes have been incorporated to the move-examples branch so they won't be lost when it goes live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alflennik alflennik alflennik approved these changes

@jnurthen jnurthen jnurthen approved these changes

@mcking65 mcking65 Awaiting requested review from mcking65

@shirsha shirsha Awaiting requested review from shirsha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch example using HTML button clashes with website CSS
5 participants
@jongund @mcking65 @a11ydoer @alflennik @jnurthen