Update GitHub workflows to use new content tree (Issue 2418 task 10) #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcking65
changed the title
nschonni
reviewed
Sep 5, 2022
There was a problem hiding this comment.
Taking a quick look at the branch structure, it mostly makes sense, except that the aria-practices-DeletedSectionsArchive.html still exists (but maybe is supposed to be deleted in a different PR) and the old coding-templates I believe are now content-templates folder that needs to be ignored
| @@ -6,9 +6,8 @@ on: | |||
| - ".github/workflows/regression.yml" | |||
| - "package*.json" | |||
| - "test/**" | |||
| - "examples/**" | |||
| - "!examples/landmarks/**" | |||
| - "!examples/coding-template/**" | |||
There was a problem hiding this comment.
I think this still exists as content-templates now
|
I just removed aria-practices-DeletedSectionsArchive.html from the move-examples branch. |
|
Yeah, I delete the comment about the Archive file, but I don't think the one about the content templates was addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2418 for more information about the task. Note that the build will fail until the changes on the move-examples-6 branch (#2441) are approved and merged.