Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace aria-practices.html with a new content tree and move examples into the patterns branch of the tree #2417

Merged
merged 168 commits into from
Dec 7, 2022
Merged
Show file tree
Hide file tree
Changes from 167 commits
Commits
Show all changes
168 commits
Select commit Hold shift + click to select a range
645e286
Create content directory structure and move all content out of exampl…
mcking65 Jul 24, 2022
14d066e
Add accordion pattern index.html
mcking65 Jul 24, 2022
b6b3b51
Adjust headings
mcking65 Jul 24, 2022
44aec91
Adjust example link href
mcking65 Jul 24, 2022
6e623fc
adjust href values in accordion example
mcking65 Jul 25, 2022
49d7c9a
Rename accordion pattern file
mcking65 Jul 25, 2022
9777f74
Adjust href of links to accordion pattern file
mcking65 Jul 25, 2022
1ebb85c
Add missing pattern directories
mcking65 Jul 25, 2022
08ff32f
Add alert pattern
mcking65 Jul 25, 2022
d0024b0
Add H2 headings for descriptions
mcking65 Jul 25, 2022
be1d75c
Add alert dialog pattern
mcking65 Jul 25, 2022
730b4b5
Add a stub pattern file for each pattern
mcking65 Jul 27, 2022
beafe9e
Rename accordion, alert, and alert dialog pattern files to put -patte…
mcking65 Jul 27, 2022
9b7ed6b
Update href of links to accordion pattern
mcking65 Jul 27, 2022
f34ba12
Add about h2
mcking65 Jul 27, 2022
d2c6734
Fix href for links to alert and alert dialog patterns
mcking65 Jul 27, 2022
ed01547
Move multithumb slider example from slider pattern to slider-multithu…
mcking65 Jul 27, 2022
d68f5de
Add breadcrumb pattern content
mcking65 Jul 30, 2022
3f392b4
Add button pattern content
mcking65 Jul 30, 2022
89f124d
Add content for carousel pattern
mcking65 Jul 31, 2022
c0ee119
Add checkbox pattern content
mcking65 Jul 31, 2022
25a7c73
Add combobox pattern content
mcking65 Jul 31, 2022
3e74870
Add modal dialog pattern content
mcking65 Jul 31, 2022
f58411a
Add section markup for about this pattern section and remove no-toc c…
mcking65 Jul 31, 2022
ea1679d
Add disclosure pattern content
mcking65 Jul 31, 2022
a96a844
Add feed pattern content
mcking65 Jul 31, 2022
d88c251
Add grid pattern content
mcking65 Jul 31, 2022
afa7007
Add link pattern content
mcking65 Jul 31, 2022
ff7d84e
Add listbox pattern content
mcking65 Jul 31, 2022
25eb07d
Rename breadcrumb example file from index to breadcrumb
mcking65 Jul 31, 2022
041e111
Update breadcrubm example
mcking65 Jul 31, 2022
c5d49c3
Update href of breadcrumb example link
mcking65 Jul 31, 2022
c599798
Put section tags around about this example section
mcking65 Jul 31, 2022
1e050e3
button example update with issue 2418
a11ydoer Aug 1, 2022
b249b60
carousel-1 pre-nav example update with issue 2418
a11ydoer Aug 1, 2022
f758b70
update carousel tab list example with issue 2418
a11ydoer Aug 1, 2022
6635198
updating two checkbox example code with issue 2418
a11ydoer Aug 1, 2022
c1ea149
update example file with issue 2418
a11ydoer Aug 1, 2022
d8bb191
update example with issue 2418 but js/utils.js file is missing
a11ydoer Aug 1, 2022
e9fde13
example udpate with issue 2814, dialog example is also missing ../js/…
a11ydoer Aug 1, 2022
32e82e1
updated the design pattern URL in datepicker dialog example file
a11ydoer Aug 1, 2022
9f53926
update disclosure example with issue 2418
a11ydoer Aug 1, 2022
50f4168
update feed example with issue 2418
a11ydoer Aug 1, 2022
cf37083
update feedDisplay example, added h2 and section temporarily, need to…
a11ydoer Aug 1, 2022
3ad17d9
update the feed example with issue 2418
a11ydoer Aug 1, 2022
0797a17
update grid pattern examples with issue 2418
a11ydoer Aug 1, 2022
6af670a
update link pattern examples with issue 2418
a11ydoer Aug 1, 2022
3c1e0be
update 4 listbox pattern examples with issue 2418
a11ydoer Aug 1, 2022
71c276e
update 3 menu button pattern examples with issue 2418
a11ydoer Aug 1, 2022
b237820
update 2 menu and menubar pattern examples with issue 2418
a11ydoer Aug 1, 2022
002e5bc
update meter pattern example file with issue 2418
a11ydoer Aug 1, 2022
587e79d
update radio group pattern example file with issue 2418
a11ydoer Aug 1, 2022
431b702
removed apg 1.2 from title tag
a11ydoer Aug 2, 2022
7529646
updated the link for the button pattern
a11ydoer Aug 2, 2022
80ccdfb
updated the slider pattern example files with issue 2418
a11ydoer Aug 2, 2022
202e4e8
updated cross references to slider examples(slider and slider-multith…
a11ydoer Aug 2, 2022
7c9b08a
remove empty line before closing of main tag
a11ydoer Aug 2, 2022
d7f9c1f
update datepicker spinbuttons file with issue 2418 list
a11ydoer Aug 2, 2022
8651677
updated similar example links in spinbutton example file
a11ydoer Aug 2, 2022
7e21271
update switch example files with issue 2418 list
a11ydoer Aug 2, 2022
29b1b9e
update table pattern example files with issue 2418 list
a11ydoer Aug 2, 2022
4585dfe
update tabs pattern example files with issue 2418 list
a11ydoer Aug 2, 2022
88a435b
update toolbar pattern example files with issue 2418 list
a11ydoer Aug 2, 2022
70daff2
update multiple cross reference to treeview examples and treegrid pat…
a11ydoer Aug 2, 2022
71bcfdc
update treeview pattern example files with issue 2418 list
a11ydoer Aug 2, 2022
da92a32
Implement 2418 task 6
alflennik Aug 18, 2022
c5b8056
Address PR 2441 feedback
alflennik Aug 23, 2022
d9c8694
Implement 2418 task 10
alflennik Sep 1, 2022
5ca99e7
Add menubar pattern content
mcking65 Sep 5, 2022
85aab94
Add menu button pattern content
mcking65 Sep 5, 2022
c19da95
Add meter pattern content
mcking65 Sep 5, 2022
7e1cb21
Add radio group pattern content
mcking65 Sep 5, 2022
1dff33b
Add slider pattern content and fix radio heading levels
mcking65 Sep 5, 2022
6fc5307
Add multi-thumb slider pattern content
mcking65 Sep 5, 2022
6b32ae6
Add spinbutton pattern content
mcking65 Sep 5, 2022
e7eeaee
Add switch pattern content
mcking65 Sep 5, 2022
b4ef34f
Add table pattern content
mcking65 Sep 5, 2022
1bc8afb
Add tabs pattern content
mcking65 Sep 5, 2022
789a6f0
Add toolbar pattern content
mcking65 Sep 6, 2022
791161f
Add tooltip pattern content
mcking65 Sep 6, 2022
64de8c0
Add treeview pattern content
mcking65 Sep 6, 2022
b60f241
Add treegrid pattern content
mcking65 Sep 6, 2022
156b9f0
Add window splitter pattern content
mcking65 Sep 6, 2022
5e05450
Remove patterns from aria-practices.html
mcking65 Sep 6, 2022
39b2a6d
Fix missing opening title tag in table pattern
mcking65 Sep 6, 2022
a186c8d
Remove aria-practices-DeletedSectionsArchive.html
mcking65 Sep 6, 2022
162c743
Infrastructure: update globs for file moves (#2467)
nschonni Sep 6, 2022
22a3086
Merge pull request #2464 from w3c/move-examples-10
alflennik Sep 7, 2022
a203048
Merge branch 'main' into move-examples-6
alflennik Sep 22, 2022
e9e5b41
Address PR 2441 feedback
alflennik Sep 22, 2022
8189a95
Merge branch 'move-examples' into move-examples-6
alflennik Sep 22, 2022
e626b56
Merge pull request #2441 from w3c/move-examples-6
alflennik Sep 22, 2022
910362f
Revise index generation to use new content tree (Issue 2418 task 8) (…
alflennik Sep 23, 2022
b5afdfe
Move practices from aria-practices.html to new content tree (#2479)
mcking65 Sep 25, 2022
ad54942
Remove index section from aria-practices.html
mcking65 Sep 25, 2022
4d66a99
Restore Home page index.html to root of content tree
mcking65 Sep 27, 2022
2751872
Fix links to practices and patterns (pull #2483)
mcking65 Sep 28, 2022
d58ab5f
Fix link text in pattern and example files
mcking65 Sep 28, 2022
c7e594f
Remove class notoc
mcking65 Sep 28, 2022
a9e6340
Add missing keyboard_interaction section IDs to patterns
mcking65 Sep 28, 2022
baddbec
Add missing roles_states_properties IDs to patterns
mcking65 Sep 28, 2022
116c79b
Fix inconsistent IDs and broken links to keyboard and roles, states, …
mcking65 Sep 28, 2022
42ea301
Rearrangeable Listbox Example: Add note on APG vs. browser multiselec…
smhigley Oct 2, 2022
dccfe2e
Complete consistency pass over source code
alflennik Oct 4, 2022
b37c8e0
Ensure consistent self-closing tag formatting
alflennik Oct 4, 2022
43988fc
Revert erroneously changed content index file
alflennik Oct 4, 2022
7ee334d
Ensure consistent self-closing tag formatting
alflennik Oct 4, 2022
67f0c02
Fix dependency of data grid examples on explicitly loaded util script
alflennik Oct 4, 2022
73c01b4
Merge branch 'move-examples' into move-examples-consistency
alflennik Oct 4, 2022
12d5fce
Regression test fixes following example script changes
alflennik Oct 4, 2022
bda80ed
Add utils script to all examples
alflennik Oct 4, 2022
10a52ec
Regression test fixes following example script changes
alflennik Oct 4, 2022
f07bed9
Resolve additional example inconsistencies
alflennik Oct 4, 2022
e50a300
Address issue 2488
alflennik Oct 5, 2022
4850cac
Address feedback on PR 2499
alflennik Oct 6, 2022
a110453
Merge branch 'move-examples-consistency' into move-examples-alert-dialog
alflennik Oct 6, 2022
c869793
Update alert-dialog in example index
alflennik Oct 6, 2022
bfe2ecc
Place long anchor tags on their own lines
alflennik Oct 7, 2022
2a4f2ff
Merge branch 'move-examples-consistency' into move-examples-alert-dialog
alflennik Oct 7, 2022
4862c99
Address PR 2502 feedback move alertdialog
alflennik Oct 20, 2022
e650074
Switch Example using Button: Fix white on white bug (Pull #2482)
jongund Oct 4, 2022
b54ef15
Consistency pass over source code (Issue 2418 Task) (#2499)
alflennik Oct 24, 2022
3b77fad
Merge branch 'move-examples' into move-examples-alert-dialog
alflennik Oct 26, 2022
820360b
Merge pull request #2502 from w3c/move-examples-alert-dialog
alflennik Oct 26, 2022
5c5f372
Update coverage report script to process new content tree and put out…
alflennik Oct 27, 2022
07859e9
Unnest treeview examples for consistency (issue 2418 task) (pull #2517)
alflennik Oct 27, 2022
c148931
Run reference-tables.js and coverage-reports.js
mcking65 Oct 27, 2022
ffb2164
Create about and read-first files
mcking65 Oct 31, 2022
36614b8
delete content from aria-practices.html
mcking65 Oct 31, 2022
f1f3954
Add acknowledgements and references to about page
mcking65 Oct 31, 2022
fe6507b
Add names to cspell config
mcking65 Nov 1, 2022
9b37c57
Add more names to spelling config
mcking65 Nov 1, 2022
8e242ae
Sort words array in cspell config
mcking65 Nov 1, 2022
ea73dc3
Fix hrefs in examples notice.html
mcking65 Nov 1, 2022
f417aa5
Update copy in notice.html to match copy used in production
mcking65 Nov 1, 2022
dcc2bba
Fix notes in button and combobox patterns
mcking65 Nov 2, 2022
e1ed080
Fix slider warning
mcking65 Nov 2, 2022
8a1234e
updated markup for notes
jongund Nov 2, 2022
0d63ee3
udpated warning markup
jongund Nov 2, 2022
e7adbe6
Merge pull request #2521 from w3c/move-about
alflennik Nov 9, 2022
49e8c74
Implement fixes for task 11 of issue 2417
alflennik Nov 10, 2022
2141c2c
Apply checkbox fixes from PR 2518
alflennik Nov 10, 2022
4cc3623
Support spec links without Respec
alflennik Nov 11, 2022
dcab965
Make spec link fixer usable in node scripts
alflennik Nov 11, 2022
ef77670
Make spec link fixer usable in node scripts pt 2
alflennik Nov 11, 2022
8219af3
Fix spelling failure
alflennik Nov 11, 2022
ea10955
Editorial revision to checkbox description
mcking65 Nov 11, 2022
e41a28f
Editorial revision to intro of grid and table properties practice
mcking65 Nov 11, 2022
a7d1de8
Fix broken links
alflennik Nov 16, 2022
4f7f89b
Merge branch 'move-examples-build-fixes' of https://github.com/w3c/ar…
alflennik Nov 16, 2022
88a10f6
Implement link checker
alflennik Nov 16, 2022
f41e6bb
Trigger link-checker
alflennik Nov 16, 2022
67b96e5
Polish link-checker workflow
alflennik Nov 16, 2022
2b6a26b
Address PR 2537 feedback
alflennik Nov 16, 2022
72c91b6
Merge branch 'move-examples-build-fixes' into link-checker
alflennik Nov 16, 2022
7fc172f
Add PR 2543 support for updated PR 2537
alflennik Nov 16, 2022
c4f3bbe
Fix garbled text on about page
alflennik Nov 17, 2022
d5bb510
Query string working with wai-aria-practices link rewrites
alflennik Nov 17, 2022
82c2831
Merge pull request #2532 from w3c/notes-and-warnings
alflennik Nov 17, 2022
432dad7
Merge branch 'move-examples' into move-examples-build-fixes
alflennik Nov 17, 2022
ac1e84b
Make warnings, notes and advisements consistent
alflennik Nov 17, 2022
a3a2d04
Address PR 2537 feedback support h5s in class=note
alflennik Nov 22, 2022
8a603a2
Merge pull request #2537 from w3c/move-examples-build-fixes
alflennik Nov 22, 2022
bb45ea4
Merge pull request #2543 from w3c/link-checker
alflennik Nov 22, 2022
fffe694
Address PR 2417 feedback code block spacing
alflennik Dec 1, 2022
d233151
Merge branch 'main' into move-examples
alflennik Dec 1, 2022
be777d0
Comment out flaky test
alflennik Dec 1, 2022
feaee5b
Update landmark index link see issue 172
alflennik Dec 6, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 3 additions & 3 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
**/*.min.js
common/
examples/landmarks/js/visua11y.js
examples/js/highlight.pack.js
examples/js/skipto.js
content/patterns/landmarks/examples/js/visua11y.js
content/shared/js/highlight.pack.js
content/shared/js/skipto.js
8 changes: 8 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,14 @@
"strict": 0,
"no-unused-vars": ["error", { "varsIgnorePattern": "SkipToConfig" }]
}
},
{
"files": [ "content/shared/js/app.js" ],
"parserOptions": { "ecmaVersion": 11 }
},
{
"files": [ "content/shared/js/specLinks.mjs" ],
"parserOptions": { "sourceType": "module" }
}
]
}
4 changes: 2 additions & 2 deletions .github/workflows/coverage-report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ name: Regression Tests Coverage Report
on:
pull_request_target:
paths:
- "examples/**"
- "content/**/examples/**"
- "test/**"
- "!examples/landmarks/**"
- "!content/landmarks/examples/**"

permissions:
contents: read
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/examples.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ on:
paths:
- "package*.json"
- ".github/workflows/examples.yml"
- "examples/**"
- "content/**/examples/**"
- "scripts/reference-tables.*"
pull_request:
paths:
- "package*.json"
- ".github/workflows/examples.yml"
- "examples/**"
- "content/**/examples/**"
- "scripts/reference-tables.*"

jobs:
Expand Down
22 changes: 22 additions & 0 deletions .github/workflows/link-checker.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: Link Checker

on: [push, pull_request]

jobs:
link-checker:
runs-on: ubuntu-latest

steps:
- name: Clone repository
uses: actions/checkout@v3

- name: Set up Node.js
uses: actions/setup-node@v3
with:
cache: npm

- name: Install npm dependencies
run: npm ci

- name: Run link checker
run: npm run link-checker
10 changes: 4 additions & 6 deletions .github/workflows/regression.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@ on:
- ".github/workflows/regression.yml"
- "package*.json"
- "test/**"
- "examples/**"
- "!examples/landmarks/**"
- "!examples/coding-template/**"
- "content/**/examples/**"
- "!content/landmarks/examples/**"
push:
branches-ignore:
- main
Expand All @@ -17,9 +16,8 @@ on:
- ".github/workflows/regression.yml"
- "package*.json"
- "test/**"
- "examples/**"
- "!examples/landmarks/**"
- "!examples/coding-template/**"
- "content/**/examples/**"
- "!content/landmarks/examples/**"

jobs:
regression:
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/spelling.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ on:
- "!**/*.min.js"
- "!**/*.pack.js"
- "!**/*.paint"
- "!aria-practices-DeletedSectionsArchive.html"
- "!examples/landmarks/css/bootstrap.css"
- "!content/patterns/landmarks/examples/css/bootstrap.css"
- "!common/**"
- "!respec-config.js"

Expand All @@ -20,8 +19,7 @@ on:
- "!**/*.min.js"
- "!**/*.pack.js"
- "!**/*.paint"
- "!aria-practices-DeletedSectionsArchive.html"
- "!examples/landmarks/css/bootstrap.css"
- "!content/patterns/landmarks/examples/css/bootstrap.css"
- "!common/**"
- "!respec-config.js"

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/wai-trigger-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
paths:
- ".github/workflows/wai-trigger-deploy.yml"
- "common/**"
- "examples/**"
- "content/**/examples/**"
- "img/**"
- "aria-practices.html"
- "index.html"
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/wai-trigger-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ on:
- "scripts/reference-tables.*"
- "**/*.js"
- "test/**"
- "examples/**"
- "content/**/examples/**"
- "aria-practices.html"
- "index.html"
- "!examples/landmarks/**"
- "!examples/coding-template/**"
- "!content/landmarks/examples/**"
- "!coding-template/**"
- "!common/**"

jobs:
Expand Down
19 changes: 19 additions & 0 deletions .link-checker.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
module.exports = {
filesToIgnore: ['content/shared/templates/example-usage-warning.html'],
excludedLinks: {
'content/patterns/menubar/examples/menubar-navigation.html': [
'#ex1 [role=menuitem]',
],
'content/patterns/treeview/examples/treeview-navigation.html': [
'#ex1 [role=treeitem]',
],
'content/patterns/carousel/examples/carousel-2-tablist.html': [
'.carousel-image a',
],
},
ignoreHashesOnExternalPagesMatchingRegex: [
// Some hash links are resolved with JS and are therefore difficult to check algorithmically
/^https:\/\/github\.com\/.*\/wiki\//,
/^https:\/\/html\.spec\.whatwg\.org\/multipage\//,
],
};
Loading